Removed output_min and output_max for mean_nd qs8, as they are not needed.

PiperOrigin-RevId: 672528666

Author: Misha Gutman

include/xnnpack.h

@@ -5190,8 +5190,6 @@ enum xnn_status xnn_create_mean_nd_qs8(
   float scale,
   int8_t input_zero_point,
   int8_t output_zero_point,
-  int8_t output_min,
-  int8_t output_max,
   uint32_t flags,
   xnn_operator_t* mean_op_out);
 

src/microparams-init.c

@@ -2248,16 +2248,12 @@ size_t xnn_init_qs8_mean_minmax_scalar_params(
   float scale,
   int32_t num_elements,
   int8_t input_zero_point,
-  int8_t output_zero_point,
-  int8_t output_min,
-  int8_t output_max)
+  int8_t output_zero_point)
 {
   params->scalar.scale = scale;
   params->scalar.num_elements = num_elements;
   params->scalar.input_zero_point = input_zero_point;
   params->scalar.output_zero_point = output_zero_point;
-  params->scalar.output_min = output_min;
-  params->scalar.output_max = output_max;
   return sizeof(params->scalar);
 }
 

src/operator-run.c

@@ -7,6 +7,7 @@
 // LICENSE file in the root directory of this source tree.
 
 #include <assert.h>
+#include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <string.h>
@@ -2233,8 +2234,7 @@ void xnn_compute_contiguous_reduce(
     }
 
     struct xnn_f32_qs8_cvt_params cvt_params;
-    xnn_init_f32_qs8_cvt_scalar_params(&cvt_params, context->params.qs8_mean.scalar.scale, context->params.qs8_mean.scalar.output_zero_point,
-                                context->params.qs8_mean.scalar.output_min, context->params.qs8_mean.scalar.output_max);
+    xnn_init_f32_qs8_cvt_scalar_params(&cvt_params, context->params.qs8_mean.scalar.scale, context->params.qs8_mean.scalar.output_zero_point, INT8_MIN, INT8_MAX);
     context->cvt_ukernel(context->accumulation_element_size * output2_block_size, workspace_ptr,
                          output_ptr, /*params=*/&cvt_params);
   }
@@ -2305,8 +2305,7 @@ void xnn_compute_discontiguous_reduce(
     }
 
     struct xnn_f32_qs8_cvt_params cvt_params;
-    xnn_init_f32_qs8_cvt_scalar_params(&cvt_params, context->params.qs8_mean.scalar.scale, context->params.qs8_mean.scalar.output_zero_point,
-                                context->params.qs8_mean.scalar.output_min, context->params.qs8_mean.scalar.output_max);
+    xnn_init_f32_qs8_cvt_scalar_params(&cvt_params, context->params.qs8_mean.scalar.scale, context->params.qs8_mean.scalar.output_zero_point, INT8_MIN, INT8_MAX);
     context->cvt_ukernel(context->accumulation_element_size * output2_block_size, workspace_ptr,
                          output_ptr, /*params=*/&cvt_params);
   }

src/operators/reduce-nd.c

@@ -80,8 +80,6 @@ enum xnn_status xnn_create_mean_nd_qs8(
   float scale,
   int8_t input_zero_point,
   int8_t output_zero_point,
-  int8_t output_min,
-  int8_t output_max,
   uint32_t flags,
   xnn_operator_t* mean_op_out)
 {
@@ -96,7 +94,7 @@ enum xnn_status xnn_create_mean_nd_qs8(
   }
 
   struct xnn_qs8_mean_minmax_params params;
-  rsum_config->init.qs8_mean(&params, scale, -1, input_zero_point, output_zero_point, output_min, output_max);
+  rsum_config->init.qs8_mean(&params, scale, -1, input_zero_point, output_zero_point);
 
   return create_mean_nd(
     flags,

src/xnnpack/microfnptr.h

@@ -2521,9 +2521,7 @@ typedef size_t (*xnn_init_qs8_mean_minmax_params_fn)(
   float scale,
   int32_t num_elements,
   int8_t input_zero_point,
-  int8_t output_zero_point,
-  int8_t output_min,
-  int8_t output_max);
+  int8_t output_zero_point);
 
 typedef size_t (*xnn_init_f32_qu8_cvt_params_fn)(
   struct xnn_f32_qu8_cvt_params params[XNN_MIN_ELEMENTS(1)],

src/xnnpack/microparams-init.h

@@ -243,9 +243,7 @@ XNN_INTERNAL size_t xnn_init_f32_scale_scalar_params(
     float scale,                                                  \
     int32_t num_elements,                                         \
     int8_t input_zero_point,                                      \
-    int8_t output_zero_point,                                     \
-    int8_t output_min,                                            \
-    int8_t output_max);
+    int8_t output_zero_point);
 
 DECLARE_INIT_QS8_MEAN_MINMAX_PARAMS_FUNCTION(xnn_init_qs8_mean_minmax_scalar_params)
 

src/xnnpack/microparams.h

@@ -377,8 +377,6 @@ struct xnn_qs8_mean_minmax_params {
     int32_t num_elements;
     int8_t input_zero_point;
     int8_t output_zero_point;
-    int8_t output_min;
-    int8_t output_max;
   } scalar;
 };
 

test/mean-operator-tester.h

@@ -434,7 +434,6 @@ class MeanOperatorTester {
 
       const xnn_status status = xnn_create_mean_nd_qs8(
           input_scale * output_scale, input_zero_point, output_zero_point,
-          quantized_output_min, quantized_output_max,
           /*flags=*/0, &mean_op);
       if (status == xnn_status_unsupported_hardware) {
         GTEST_SKIP();