Fix build error in expression tests (codeplaysoftware#359)

Update Gemm documentation with TARGET changes
Fix typos in rotmg comments

Author: fabiomestre

doc/Gemm.md

@@ -163,8 +163,8 @@ The notable calls in the stack are (all located in `src/interface/gemm_interface
 
 ## GEMM Backends
 
-GEMM backends are a mechanism to provide different compile-time configurations for different hardware platforms/backends. 
-Backend selection is controlled by passing the cmake variable `TARGET` during CMake configuration, for example passing `-DTARGET=INTEL_GPU` would select the appropriate configurations for Intel GPUs. 
+GEMM backends are a mechanism to provide different compile-time configurations for different hardware platforms/backends.
+Backend selection is controlled by passing the cmake variable `TUNING_TARGET` during CMake configuration, for example passing `-DTUNING_TARGET=INTEL_GPU` would select the appropriate configurations for Intel GPUs.
 This cmake variable causes a corresponding define for the selected platform to be included in the source which then controls backend selection through `#ifdef`s in `src/interface/blas3/backend/backend.hpp` like so:
 
 ```c++
@@ -392,7 +392,7 @@ Configurations are provided per backend target and will be generated for each da
 As an example let's look at the configurations in `CmakeFunctionHelper.cmake` for the `RCAR` target backend, inside the function `generate_blas_gemm_objects`:
 
 ```cmake
-if(${TARGET} STREQUAL "RCAR")
+if(${TUNING_TARGET} STREQUAL "RCAR")
   set(supported_types
     "float"
   )

src/operations/blas1_trees.hpp

@@ -662,7 +662,7 @@ SYCL_BLAS_INLINE typename Rotmg<operand_t>::value_t Rotmg<operand_t>::eval(
    * overflows. Consult the papers above for more info */
   constexpr value_t gamma = static_cast<value_t>(4096.0);
 
-  /* Square of gamma. It is hardcoded to avoid computing it on every call */
+  /* Square of gamma. */
   constexpr value_t gamma_sq = gamma * gamma;
 
   /* Inverse of the square of gamma (i.e. 1 / (gamma * gamma)) */
@@ -703,7 +703,7 @@ SYCL_BLAS_INLINE typename Rotmg<operand_t>::value_t Rotmg<operand_t>::eval(
    * Scaling may be needed */
   else if ((d1 == zero::value() || x1 == zero::value()) && d2 > zero::value()) {
     flag = clts_flag::value();
-    /* clts_matrix assumes h12 and h21 values. But they still need to be set
+    /* clts_flag assumes h12 and h21 values. But they still need to be set
      * because of possible re-scaling */
     h12 = one::value();
     h21 = m_one::value();
@@ -727,7 +727,7 @@ SYCL_BLAS_INLINE typename Rotmg<operand_t>::value_t Rotmg<operand_t>::eval(
 
     if (abs_c > abs_s) {
       flag = sltc_flag::value();
-      /* sltc_matrix assumes h11 and h22 values. But they still need to be set
+      /* sltc_flag assumes h11 and h22 values. But they still need to be set
        * because of possible re-scaling */
       h11 = one::value();
       h22 = one::value();
@@ -750,7 +750,7 @@ SYCL_BLAS_INLINE typename Rotmg<operand_t>::value_t Rotmg<operand_t>::eval(
       } else {
         flag = clts_flag::value();
 
-        /* clts_matrix assumes h12 and h21 values. But they still need to be set
+        /* clts_flag assumes h12 and h21 values. But they still need to be set
          * because of possible re-scaling */
         h12 = one::value();
         h21 = m_one::value();

test/exprtest/CMakeLists.txt

@@ -22,8 +22,6 @@
 # *  @filename CMakeLists.txt
 # *
 # **************************************************************************/
-add_definitions(-D${TARGET})
-
 set(SYCLBLAS_EXPRTEST ${CMAKE_CURRENT_SOURCE_DIR})
 
 # compiling tests
@@ -36,7 +34,11 @@ set(SYCL_EXPRTEST_SRCS
 foreach(blas_test ${SYCL_EXPRTEST_SRCS})
   get_filename_component(test_exec ${blas_test} NAME_WE)
   add_executable(${test_exec} main.cpp ${blas_test})
-  target_compile_definitions(${test_exec} PRIVATE -DBLAS_INDEX_T=${BLAS_TEST_INDEX_TYPE})
+  if(is_computecpp)
+    set_property(TARGET ${test_exec} PROPERTY CXX_STANDARD 14)
+  endif()
+  # -DTUNING_TARGET is needed when using SYCL-BLAS in header only mode.
+  target_compile_definitions(${test_exec} PRIVATE -DBLAS_INDEX_T=${BLAS_TEST_INDEX_TYPE} -D${TUNING_TARGET})
   target_link_libraries(${test_exec} PRIVATE gtest_main blas::blas sycl_blas)
   target_include_directories(${test_exec} PRIVATE "${CMAKE_CURRENT_SOURCE_DIR}/.." ${CBLAS_INCLUDE} ${SYCLBLAS_SRC} ${SYCLBLAS_COMMON_INCLUDE_DIR})
   add_sycl_to_target(

test/unittest/blas1/blas1_rotmg_test.cpp

@@ -169,7 +169,7 @@ void RotmgTest<scalar_t>::validate_with_reference() {
  * side of the following formula is calculated by rotm.
  *
  * x1_output * sqrt(d1_output) = [ h11 h12 ] * [ x1_input]
- * 0.0       * sqrt(d2_output)   [h21  h22 ]   [ y1_input]
+ * 0.0       * sqrt(d2_output)   [ h21 h22 ]   [ y1_input]
  */
 template <typename scalar_t>
 void RotmgTest<scalar_t>::validate_with_rotm() {