[NO-JIRA] Fix client gas config (#153)

* remove gas overrides from read functions erc721

* set gas limit

* remove gas overrides from read functions erc20

* remove gas overrides from read functions erc721 by id

Author: allan-almeida-imtbl

clients/config/overrides.ts

@@ -4,4 +4,5 @@ import { CallOverrides } from "@ethersproject/contracts";
 export const defaultGasOverrides: CallOverrides = {
   maxPriorityFeePerGas: 10e9, // 10 Gwei
   maxFeePerGas: 15e9,
+  gasLimit: 200000, // Expected when setting the above properties
 };

clients/erc20.ts

@@ -20,7 +20,7 @@ export class ERC20Client {
    * @returns a promise that resolves with a BigNumber that represents the amount of tokens in existence
    */
   public async totalSupply(provider: Provider, overrides: CallOverrides = {}): Promise<BigNumber> {
-    return this.contract.connect(provider).totalSupply({ ...defaultGasOverrides, ...overrides });
+    return this.contract.connect(provider).totalSupply(overrides);
   }
 
   /**
@@ -31,7 +31,7 @@ export class ERC20Client {
     account: PromiseOrValue<string>,
     overrides: CallOverrides = {}
   ): Promise<BigNumber> {
-    return this.contract.connect(provider).balanceOf(account, { ...defaultGasOverrides, ...overrides });
+    return this.contract.connect(provider).balanceOf(account, overrides);
   }
 
   /**
@@ -43,7 +43,7 @@ export class ERC20Client {
     spender: PromiseOrValue<string>,
     overrides: CallOverrides = {}
   ): Promise<BigNumber> {
-    return this.contract.connect(provider).allowance(owner, spender, { ...defaultGasOverrides, ...overrides });
+    return this.contract.connect(provider).allowance(owner, spender, overrides);
   }
 
   /**

clients/erc721-mint-by-id.ts

@@ -31,14 +31,14 @@ export class ERC721MintByIDClient {
    * @returns the DEFAULT_ADMIN_ROLE as a string.
    */
   public async DEFAULT_ADMIN_ROLE(provider: Provider, overrides: CallOverrides = {}): Promise<string> {
-    return await this.contract.connect(provider).DEFAULT_ADMIN_ROLE({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).DEFAULT_ADMIN_ROLE(overrides);
   }
 
   /**
    * @returns the MINTER_ROLE as a string.
    */
   public async MINTER_ROLE(provider: Provider, overrides: CallOverrides = {}): Promise<string> {
-    return await this.contract.connect(provider).MINTER_ROLE({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).MINTER_ROLE(overrides);
   }
 
   /**
@@ -49,28 +49,28 @@ export class ERC721MintByIDClient {
     owner: PromiseOrValue<string>,
     overrides: CallOverrides = {}
   ): Promise<BigNumber> {
-    return await this.contract.connect(provider).balanceOf(owner, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).balanceOf(owner, overrides);
   }
 
   /**
    * @returns the baseURI as a string.
    */
   public async baseURI(provider: Provider, overrides: CallOverrides = {}): Promise<string> {
-    return await this.contract.connect(provider).baseURI({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).baseURI(overrides);
   }
 
   /**
    * @returns the contractURI as a string.
    */
   public async contractURI(provider: Provider, overrides: CallOverrides = {}): Promise<string> {
-    return await this.contract.connect(provider).contractURI({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).contractURI(overrides);
   }
 
   /**
    * @returns admin addresses as an array of strings.
    */
   public async getAdmins(provider: Provider, overrides: CallOverrides = {}): Promise<string[]> {
-    return await this.contract.connect(provider).getAdmins({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).getAdmins(overrides);
   }
 
   /**
@@ -81,7 +81,7 @@ export class ERC721MintByIDClient {
     tokenId: PromiseOrValue<BigNumberish>,
     overrides: CallOverrides = {}
   ): Promise<string> {
-    return await this.contract.connect(provider).getApproved(tokenId, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).getApproved(tokenId, overrides);
   }
 
   /**
@@ -92,7 +92,7 @@ export class ERC721MintByIDClient {
     role: PromiseOrValue<BytesLike>,
     overrides: CallOverrides = {}
   ): Promise<string> {
-    return await this.contract.connect(provider).getRoleAdmin(role, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).getRoleAdmin(role, overrides);
   }
 
   /**
@@ -104,7 +104,7 @@ export class ERC721MintByIDClient {
     index: PromiseOrValue<BigNumberish>,
     overrides: CallOverrides = {}
   ): Promise<string> {
-    return await this.contract.connect(provider).getRoleMember(role, index, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).getRoleMember(role, index, overrides);
   }
 
   /**
@@ -115,7 +115,7 @@ export class ERC721MintByIDClient {
     role: PromiseOrValue<BytesLike>,
     overrides: CallOverrides = {}
   ): Promise<BigNumber> {
-    return await this.contract.connect(provider).getRoleMemberCount(role, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).getRoleMemberCount(role, overrides);
   }
 
   /**
@@ -127,7 +127,7 @@ export class ERC721MintByIDClient {
     account: PromiseOrValue<string>,
     overrides: CallOverrides = {}
   ): Promise<boolean> {
-    return await this.contract.connect(provider).hasRole(role, account, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).hasRole(role, account, overrides);
   }
 
   /**
@@ -139,16 +139,14 @@ export class ERC721MintByIDClient {
     operator: PromiseOrValue<string>,
     overrides: CallOverrides = {}
   ): Promise<boolean> {
-    return await this.contract
-      .connect(provider)
-      .isApprovedForAll(owner, operator, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).isApprovedForAll(owner, operator, overrides);
   }
 
   /**
    * @returns the name of the contract as a string.
    */
   public async name(provider: Provider, overrides: CallOverrides = {}): Promise<string> {
-    return await this.contract.connect(provider).name({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).name(overrides);
   }
 
   /**
@@ -159,7 +157,7 @@ export class ERC721MintByIDClient {
     tokenId: PromiseOrValue<BigNumberish>,
     overrides: CallOverrides = {}
   ): Promise<string> {
-    return await this.contract.connect(provider).ownerOf(tokenId, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).ownerOf(tokenId, overrides);
   }
 
   /**
@@ -172,14 +170,14 @@ export class ERC721MintByIDClient {
     tokenId: PromiseOrValue<BigNumberish>,
     overrides: CallOverrides = {}
   ): Promise<BigNumber> {
-    return await this.contract.connect(provider).nonces(tokenId, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).nonces(tokenId, overrides);
   }
 
   /**
    * @returns the operator allowlist as a string.
    */
   public async operatorAllowlist(provider: Provider, overrides: CallOverrides = {}): Promise<string> {
-    return await this.contract.connect(provider).operatorAllowlist({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).operatorAllowlist(overrides);
   }
 
   /**
@@ -191,16 +189,14 @@ export class ERC721MintByIDClient {
     _salePrice: PromiseOrValue<BigNumberish>,
     overrides: CallOverrides = {}
   ): Promise<[string, BigNumber]> {
-    return await this.contract
-      .connect(provider)
-      .royaltyInfo(_tokenId, _salePrice, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).royaltyInfo(_tokenId, _salePrice, overrides);
   }
 
   /**
    * @returns the symbol of the contract as a string.
    */
   public async symbol(provider: Provider, overrides: CallOverrides = {}): Promise<string> {
-    return await this.contract.connect(provider).symbol({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).symbol(overrides);
   }
 
   /**
@@ -211,14 +207,14 @@ export class ERC721MintByIDClient {
     tokenId: PromiseOrValue<BigNumberish>,
     overrides: CallOverrides = {}
   ): Promise<string> {
-    return await this.contract.connect(provider).tokenURI(tokenId, { ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).tokenURI(tokenId, overrides);
   }
 
   /**
    * @returns returns the total amount of tokens stored by the contract.
    */
   public async totalSupply(provider: Provider, overrides: CallOverrides = {}): Promise<BigNumber> {
-    return await this.contract.connect(provider).totalSupply({ ...defaultGasOverrides, ...overrides });
+    return await this.contract.connect(provider).totalSupply(overrides);
   }
 
   /**