From 2ef6154c9a58492837efcb56256379581f2d7ad1 Mon Sep 17 00:00:00 2001 From: Mohsin Khan Date: Fri, 23 May 2025 16:49:54 +0500 Subject: [PATCH] aria-required not necessary when native required present --- .../ViewHelpers/Validation/AbstractValidationViewHelper.php | 1 - .../Validation/ValidationDataAttributeViewHelper.php | 4 ---- .../Validation/DatepickerDataAttributeViewHelperTest.php | 1 - 3 files changed, 6 deletions(-) diff --git a/Classes/ViewHelpers/Validation/AbstractValidationViewHelper.php b/Classes/ViewHelpers/Validation/AbstractValidationViewHelper.php index a94457e36..5ca46a1dc 100644 --- a/Classes/ViewHelpers/Validation/AbstractValidationViewHelper.php +++ b/Classes/ViewHelpers/Validation/AbstractValidationViewHelper.php @@ -75,7 +75,6 @@ protected function addMandatoryAttributes(array $additionalAttributes, ?Field $f $additionalAttributes['data-powermail-required'] = 'true'; } } - $additionalAttributes['aria-required'] = 'true'; if ($this->isClientValidationEnabled()) { $additionalAttributes['data-powermail-required-message'] = diff --git a/Classes/ViewHelpers/Validation/ValidationDataAttributeViewHelper.php b/Classes/ViewHelpers/Validation/ValidationDataAttributeViewHelper.php index 35a1f0ae8..70aaa148a 100644 --- a/Classes/ViewHelpers/Validation/ValidationDataAttributeViewHelper.php +++ b/Classes/ViewHelpers/Validation/ValidationDataAttributeViewHelper.php @@ -96,17 +96,14 @@ protected function addMandatoryAttributesForMultipleFields( if ($field->isMandatory()) { if ($this->isNativeValidationEnabled()) { $additionalAttributes['required'] = 'required'; - $additionalAttributes['aria-required'] = 'true'; // remove required attribute if more checkboxes than 1 if ($field->getType() === 'check' && $iteration['total'] > 1) { unset($additionalAttributes['required']); - unset($additionalAttributes['aria-required']); } } else { if ($this->isClientValidationEnabled()) { $additionalAttributes['data-powermail-required'] = 'true'; - $additionalAttributes['aria-required'] = 'true'; } } if ($this->isClientValidationEnabled()) { @@ -117,7 +114,6 @@ protected function addMandatoryAttributesForMultipleFields( LocalizationUtility::translate('validationerror_mandatory_multi'); if ($field->getType() === 'check') { $additionalAttributes['data-powermail-required'] = 'true'; - $additionalAttributes['aria-required'] = 'true'; } } } diff --git a/Tests/Unit/ViewHelpers/Validation/DatepickerDataAttributeViewHelperTest.php b/Tests/Unit/ViewHelpers/Validation/DatepickerDataAttributeViewHelperTest.php index 1c09c77a3..0858296f9 100644 --- a/Tests/Unit/ViewHelpers/Validation/DatepickerDataAttributeViewHelperTest.php +++ b/Tests/Unit/ViewHelpers/Validation/DatepickerDataAttributeViewHelperTest.php @@ -64,7 +64,6 @@ public static function renderReturnsArrayDataProvider(): array 'data-datepicker-format' => 'YYYY-MM-DD HH:mm', 'data-date-value' => 'anyvalue', 'required' => 'required', - 'aria-required' => 'true', 'data-powermail-required-message' => 'validationerror_mandatory', ], ],