PROC-1219: Fix error message in case test fails

Robert Danci · Robert Danci · commit cac5323cda5b · 2023-04-13T11:39:31.000+09:00
Make it clear that Strings 'true' and 'false' are valid
diff --git a/proctor-common/src/test/java/com/indeed/proctor/common/TestRuleEvaluator.java b/proctor-common/src/test/java/com/indeed/proctor/common/TestRuleEvaluator.java
@@ -49,10 +49,10 @@ public void testEmptyRule() {
 
     @Test
     public void testLiteralRule() {
-        for (final String rule : new String[] { "${true}", "${TRUE}", "${ TRUE }" }) {
+        for (final String rule : new String[] { "${true}", "${TRUE}", "${ TRUE }", "${'TRUE'}", "${'true'}" }) {
             assertTrue("rule '" + rule + "' should be true", ruleEvaluator.evaluateBooleanRule(rule, emptyMap()));
         }
-        for (final String rule : new String[] { "${false}", "${FALSE}", "${ FALSE }" }) {
+        for (final String rule : new String[] { "${false}", "${FALSE}", "${ FALSE }", "${'FALSE'}", "${'false'}" }) {
             assertFalse("rule '" + rule + "' should be false", ruleEvaluator.evaluateBooleanRule(rule, emptyMap()));
         }
     }
@@ -96,7 +96,7 @@ public void testStandaloneMethodCalls() {
         }
 
         for (String rule : ImmutableList.of("${!context.isValid()}", "${context.isFortyTwo('47')}")) {
-            assertFalse("rule '" + rule + "' should be true for " + context, ruleEvaluator.evaluateBooleanRule(rule, context));
+            assertFalse("rule '" + rule + "' should be false for " + context, ruleEvaluator.evaluateBooleanRule(rule, context));
         }
 
         assertThatThrownBy(() -> ruleEvaluator.evaluateBooleanRule("${context.isNotFortyTwo('42')}", context))

Original file line number	Diff line number	Diff line change
`@@ -49,10 +49,10 @@ public void testEmptyRule() {`
`49`	`49`
`50`	`50`	`@Test`
`51`	`51`	`public void testLiteralRule() {`
`52`		`- for (final String rule : new String[] { "${true}", "${TRUE}", "${ TRUE }" }) {`
	`52`	`+ for (final String rule : new String[] { "${true}", "${TRUE}", "${ TRUE }", "${'TRUE'}", "${'true'}" }) {`
`53`	`53`	`assertTrue("rule '" + rule + "' should be true", ruleEvaluator.evaluateBooleanRule(rule, emptyMap()));`
`54`	`54`	`}`
`55`		`- for (final String rule : new String[] { "${false}", "${FALSE}", "${ FALSE }" }) {`
	`55`	`+ for (final String rule : new String[] { "${false}", "${FALSE}", "${ FALSE }", "${'FALSE'}", "${'false'}" }) {`
`56`	`56`	`assertFalse("rule '" + rule + "' should be false", ruleEvaluator.evaluateBooleanRule(rule, emptyMap()));`
`57`	`57`	`}`
`58`	`58`	`}`
`@@ -96,7 +96,7 @@ public void testStandaloneMethodCalls() {`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`for (String rule : ImmutableList.of("${!context.isValid()}", "${context.isFortyTwo('47')}")) {`
`99`		`- assertFalse("rule '" + rule + "' should be true for " + context, ruleEvaluator.evaluateBooleanRule(rule, context));`
	`99`	`+ assertFalse("rule '" + rule + "' should be false for " + context, ruleEvaluator.evaluateBooleanRule(rule, context));`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`assertThatThrownBy(() -> ruleEvaluator.evaluateBooleanRule("${context.isNotFortyTwo('42')}", context))`