refactor: remove the ghost-user feature

Third and last step of retiring ghost users. The creation paths went in
7e8fa2ac41, migration 0129 deletes the 14 remaining rows, and this removes the
column and every reader of it. Nothing named "ghost" survives in the source.

Migration 0130 drops `users.is_ghost`. Drizzle applies migrations in journal
order within one run, so 0129 deletes the ghosts before 0130 executes; if 0129
fails the run halts and the column is never dropped. There is no interleaving
where the column disappears while a ghost row survives and silently becomes
indistinguishable from a real account.

### Removed

- protocol: `softDeleteGhost`, `mergeGhostUser`, `findDuplicateUser` from the
  database port; `isGhost` from every entity, contact payload and member row;
  the `enrichment.enricher` module (both helpers were ghost-only).
- protocol: `buildMinimalOpportunityCard` loses its trailing
  `isCounterpartGhost` parameter and the `isGhost` field on its result.
- api: `claimGhostUser` and the session hook that called it on every login; the
  ghost-claim ON CONFLICT upsert; `softDeleteGhostByUnsubscribeToken`;
  `getSoftDeletedGhostEmails`; the ghost-invite email and its template; and
  `GET /api/unsubscribe/:token`, which existed only to soft-delete a ghost.
- cli: the `[ghost]` profile badge and `(ghost)` contact-list tag.
- web: `GhostBadge`, the avatar blur, the "hasn't joined yet" chat states, the
  invite-instead-of-chat branch on the profile page, and the `isGhost` prop
  chain through the opportunity cards.

### Behaviour that is deliberately unchanged

Four enrichment branches called `softDeleteGhost` or `mergeGhostUser`. The host
guarded both — `softDeleteGhost` returned false for any non-ghost and
`mergeGhostUser` threw — so for a real account they were already no-ops. The
non-human branch still aborts with "Non-human entity detected"; it just no
longer makes the call. Low-confidence and failed enrichment still fall through
to basic info.

`ensureNegotiatorAgent` returned null for ghosts and for missing users; it now
returns null for missing users only.

Auth signup previously upserted over a ghost on email conflict and threw for a
real user. Every conflict is now a real user, so `onConflictDoNothing` leaves
RETURNING empty and the same duplicate-signup error is thrown.

### Validation

- 0130 applied to the dry-run branch from 0129 (br-rough-night-ahk6xorm): column
  gone, 300 users / 504 contact memberships / 10547 opportunities all intact,
  and it re-applies cleanly.
- Fresh-database provisioning still works: 0009/0021/0040/0042/0089 reference
  `is_ghost` and all run before 0130 drops it.
- protocol: build clean, architecture clean, test:isolated 2176 pass / 0 fail,
  full suite at exact parity with the pre-change baseline (95 failures, all
  database-gated; 0 new, 0 masked).
- api typecheck + lint clean, CI hermetic gates green (83 + 33). cli 350 pass /
  0 fail, build + lint clean. web builds and lints clean.

Author: yanekyuk

npm/darwin-arm64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@indexnetwork/cli-darwin-arm64",
-  "version": "0.16.0",
+  "version": "0.17.0",
   "description": "Platform-specific binary for @indexnetwork/cli (macOS arm64)",
   "license": "MIT",
   "os": [

npm/darwin-x64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@indexnetwork/cli-darwin-x64",
-  "version": "0.16.0",
+  "version": "0.17.0",
   "description": "Platform-specific binary for @indexnetwork/cli (macOS x64)",
   "license": "MIT",
   "os": [

npm/linux-arm64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@indexnetwork/cli-linux-arm64",
-  "version": "0.16.0",
+  "version": "0.17.0",
   "description": "Platform-specific binary for @indexnetwork/cli (Linux arm64)",
   "license": "MIT",
   "os": [

npm/linux-x64/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@indexnetwork/cli-linux-x64",
-  "version": "0.16.0",
+  "version": "0.17.0",
   "description": "Platform-specific binary for @indexnetwork/cli (Linux x64)",
   "license": "MIT",
   "os": [

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@indexnetwork/cli",
-  "version": "0.16.0",
+  "version": "0.17.0",
   "description": "Command-line interface for Index Network",
   "license": "MIT",
   "type": "module",
@@ -20,10 +20,10 @@
     "publish:all": "bun scripts/publish.ts"
   },
   "optionalDependencies": {
-    "@indexnetwork/cli-linux-x64": "0.16.0",
-    "@indexnetwork/cli-linux-arm64": "0.16.0",
-    "@indexnetwork/cli-darwin-x64": "0.16.0",
-    "@indexnetwork/cli-darwin-arm64": "0.16.0"
+    "@indexnetwork/cli-linux-x64": "0.17.0",
+    "@indexnetwork/cli-linux-arm64": "0.17.0",
+    "@indexnetwork/cli-darwin-x64": "0.17.0",
+    "@indexnetwork/cli-darwin-arm64": "0.17.0"
   },
   "devDependencies": {
     "@types/bun": "1.3.14"

src/contact.command.ts

@@ -39,7 +39,7 @@ export async function handleContact(
       const result = await client.callTool("list_contacts", {});
       if (options.json) { console.log(JSON.stringify(result)); return; }
       if (!result.success) { output.error(result.error ?? "Failed to list contacts", 1); return; }
-      const data = result.data as { count: number; contacts: Array<{ userId: string; name: string; email: string; isGhost: boolean }> };
+      const data = result.data as { count: number; contacts: Array<{ userId: string; name: string; email: string }> };
       output.heading("Contacts");
       output.contactTable(data.contacts);
       output.dim(`\n  ${data.count} contact${data.count !== 1 ? "s" : ""}`);

src/output/formatters.ts

@@ -20,7 +20,6 @@ export interface ProfileData {
   avatar: string | null;
   location: string | null;
   socials: Array<{ label: string; value: string }> | null;
-  isGhost: boolean;
   createdAt: string;
   updatedAt: string | null;
 }
@@ -43,9 +42,8 @@ export function profileCard(data: ProfileData): string {
 
   // Name line
   const displayName = data.name ?? "(unnamed)";
-  const ghostTag = data.isGhost ? `  ${YELLOW}[ghost]${RESET}` : "";
-  const nameContent = `${BOLD}${WHITE}${displayName}${RESET}${ghostTag}`;
-  lines.push(`  ${border("|")} ${nameContent}${padTo(W - 2, stripAnsi(displayName + (data.isGhost ? "  [ghost]" : "")))}${border("|")}`);
+  const nameContent = `${BOLD}${WHITE}${displayName}${RESET}`;
+  lines.push(`  ${border("|")} ${nameContent}${padTo(W - 2, stripAnsi(displayName))}${border("|")}`);
 
   // Intro / bio
   if (data.intro) {
@@ -98,7 +96,7 @@ export function profileCard(data: ProfileData): string {
  * @param contacts - Array of contact objects from the API.
  */
 export function contactTable(
-  contacts: Array<{ userId: string; name: string; email: string; isGhost?: boolean }>,
+  contacts: Array<{ userId: string; name: string; email: string }>,
 ): void {
   if (contacts.length === 0) {
     console.log("  No contacts yet.");
@@ -108,8 +106,7 @@ export function contactTable(
   const header = `  ${"Name".padEnd(nameWidth)}  Email`;
   console.log(`${BOLD}${header}${RESET}`);
   for (const c of contacts) {
-    const ghost = c.isGhost ? ` ${DIM}(ghost)${RESET}` : "";
-    console.log(`  ${c.name.padEnd(nameWidth)}  ${c.email}${ghost}`);
+    console.log(`  ${c.name.padEnd(nameWidth)}  ${c.email}`);
   }
 }
 

src/types.ts

@@ -30,7 +30,6 @@ export interface UserData {
   avatar: string | null;
   location: string | null;
   socials: SocialLink[] | null;
-  isGhost: boolean;
   createdAt: string;
   updatedAt: string | null;
 }
@@ -148,7 +147,6 @@ export interface OpportunityDetail {
   category?: string;
   confidence?: number;
   index?: { id: string; title: string };
-  isGhost?: boolean;
   primaryActionLabel?: string;
   createdAt?: string;
   /** Present when the requested opportunity was superseded by this enriched opportunity. */

tests/output.formatters.spec.ts

@@ -36,7 +36,6 @@ describe("profileCard", () => {
         avatar: null,
         location: "San Francisco",
         socials: [{ label: "twitter", value: "@alice" }],
-        isGhost: false,
         createdAt: "2025-06-15T00:00:00Z",
         updatedAt: null,
       });
@@ -48,23 +47,6 @@ describe("profileCard", () => {
     expect(output).toContain("Member since");
   });
 
-  it("renders ghost badge", () => {
-    const output = captureLogs(() => {
-      profileCard({
-        id: "u2",
-        name: null,
-        intro: null,
-        avatar: null,
-        location: null,
-        socials: null,
-        isGhost: true,
-        createdAt: "2025-01-01T00:00:00Z",
-        updatedAt: null,
-      });
-    });
-    expect(output).toContain("(unnamed)");
-    expect(output).toContain("[ghost]");
-  });
 });
 
 // ── intentTable ─────────────────────────────────────────────────────

tests/profile.command.spec.ts

@@ -118,7 +118,6 @@ describe("ApiClient — profile methods", () => {
             avatar: "https://example.com/avatar.jpg",
             location: "San Francisco, US",
             socials: [{ label: "linkedin", value: "https://linkedin.com/in/alice" }],
-            isGhost: false,
             createdAt: "2026-01-15T00:00:00Z",
             updatedAt: "2026-03-20T00:00:00Z",
           },
@@ -130,15 +129,14 @@ describe("ApiClient — profile methods", () => {
       expect(user.name).toBe("Alice");
       expect(user.intro).toBe("ML engineer working on robotics");
       expect(user.location).toBe("San Francisco, US");
-      expect(user.isGhost).toBe(false);
     });
 
     it("sends the x-api-key header", async () => {
       let receivedApiKey = "";
       mock.on("GET", "/api/users/user-xyz", (req) => {
         receivedApiKey = req.headers.get("x-api-key") ?? "";
         return Response.json({
-          user: { id: "user-xyz", name: "Bob", isGhost: false, createdAt: "2026-01-01" },
+          user: { id: "user-xyz", name: "Bob", createdAt: "2026-01-01" },
         });
       });
 
@@ -177,14 +175,13 @@ describe("profileCard", () => {
           { label: "linkedin", value: "https://linkedin.com/in/alice" },
           { label: "github", value: "https://github.com/alice" },
         ],
-        isGhost: false,
         createdAt: "2026-01-15T00:00:00Z",
         updatedAt: "2026-03-20T00:00:00Z",
       }),
     ).not.toThrow();
   });
 
-  it("renders without throwing for a ghost user with minimal data", () => {
+  it("renders without throwing for a user with minimal data", () => {
     expect(() =>
       profileCard({
         id: "user-ghost",
@@ -193,7 +190,6 @@ describe("profileCard", () => {
         avatar: null,
         location: null,
         socials: null,
-        isGhost: true,
         createdAt: "2026-01-15T00:00:00Z",
         updatedAt: null,
       }),
@@ -208,7 +204,6 @@ describe("profileCard", () => {
       avatar: null,
       location: "Berlin, DE",
       socials: null,
-      isGhost: false,
       createdAt: "2026-01-01T00:00:00Z",
       updatedAt: null,
     });