Conversation
`User::AUTH_PUBLIC` is an int, so the config value needs to be cast to an int before checking with `===`-operator. This fixes a problem where having `GRAPHER_ACCESS_CUSTOMER=0` in .env is not giving public access. Probably fixes other cases too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User::AUTH_PUBLICis an int, so the config value needs to be cast to an int before checking with===.This fixes a problem where having
GRAPHER_ACCESS_CUSTOMER=0in .env is not giving public access. Probably fixes other cases too.I have not run the unit tests and psalm. If you think it is needed for this change, i have to take some time to set it up first.
In addition to the above, I have:
<?= $t->ee( $data ) ?>or equivalent