Skip to content

FI-3180 Remove examples, schema, and expansions from gem package #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
360dgries merged 4 commits into from
Oct 14, 2024
Merged

FI-3180 Remove examples, schema, and expansions from gem package #116

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d588e38
Remove examples, schema, and expansions from gem package
360dgries Oct 3, 2024
33917d8
Remove dev files from gem package
360dgries Oct 9, 2024
07db9c0
Add License back into gem
360dgries Oct 10, 2024
a570913
lazy load fhir packages
Jammjammjamm Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fhir_models.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ Gem::Specification.new do |spec|
spec.files = `git ls-files -z`.split("\x0").reject do |f|
f.match(%r{^(test|spec|features)/})
end
spec.files.reject! { |file| file =~ /lib\/fhir_models\/examples|lib\/fhir_models\/definitions\/schema|lib\/fhir_models\/definitions\/valuesets/}
spec.files.reject! { |file| file =~ /lib\/fhir_models\/igs\/hl7.fhir.r4.core\/package_supplement\/expansions.json/}
spec.files.reject! { |file| file =~ /lib\/fhir_models\/igs\/hl7.fhir.r4b.core\/package_supplement\/expansions.json/}
spec.files.reject! { |file| file =~ /lib\/fhir_models\/igs\/hl7.fhir.r5.core\/package_supplement\/expansions.json/}
Copy link
Copy Markdown
Contributor

@Jammjammjamm Jammjammjamm Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do this so that it isn't hard coded and won't break when we add a new version?

Copy link
Copy Markdown
Contributor Author

@360dgries 360dgries Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the regex to be version agnostic.

I've also changed the initial file gathering to be limited to those in lib, so none of the ones listed above are included anymore.

Copy link
Copy Markdown
Contributor

@Jammjammjamm Jammjammjamm Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good, but we should still include LICENSE.

Copy link
Copy Markdown
Contributor Author

@360dgries 360dgries Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back

spec.bindir = 'exe'
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']
Expand Down