Skip to content

Update to v2.0.0 of IG#45

Merged
Jammjammjamm merged 3 commits into
inferno-framework:mainfrom
ljtucker:main
Apr 30, 2025
Merged

Update to v2.0.0 of IG#45
Jammjammjamm merged 3 commits into
inferno-framework:mainfrom
ljtucker:main

Conversation

@ljtucker
Copy link
Copy Markdown
Contributor

@ljtucker ljtucker commented Apr 9, 2025

Update UDS+ Inferno Kit to test off of the v2.0.0 version of the IG:

  • Update IG and Test Kit version numbers and URLs
  • Remove Special Observation tests (now covered by the generic observation test)
    • This test also included a check that all observations were of known types. This test case has now been moved to the resource type test
  • Remove Sexual Orientation Profile tests (resource type removed from IG)
  • Update Sample Resources to match those on the current IG

Successful Test

image

Notes

This PR will initially be marked as draft for the following reasons (to be discussed with @arscan):

  • A separate task to introduce an external package that handles level 3 and 4 validation of resources will be pushed to the Test Kit. Still need to determine whether these changes should be appended to this PR or added as a new PR after this gets merged.
  • Most resources are returning with the below warning message. Need to decide whether this is an expeced and valid warning, or if the message should be suppressed for this test kit
    image

Comment thread lib/uds_plus_test_kit/manifest_tests/invalid_type_test.rb Outdated
Comment thread lib/uds_plus_test_kit/metadata.rb Outdated
title 'UDS+ Test Kit'
description <<~DESCRIPTION
The UDS+ Test Kit validates the conformance of a server to the [UDS+ IG v1.1.0](https://fhir.org/guides/hrsa/uds-plus/STU1.1/). The included tests function as a rudimentary data receiver. This receiver will take a provided Import Manifest, either as an HTTP location or as a raw json, and validate its contents. This includes validating the structure of the manifest, as well as the structure of the data the manifest points to.
The UDS+ Test Kit validates the conformance of a server to the [UDS+ IG v2.0.0](https://fhir.org/guides/hrsa/uds-plus/index.html). The included tests function as a rudimentary data receiver. This receiver will take a provided Import Manifest, either as an HTTP location or as a raw json, and validate its contents. This includes validating the structure of the manifest, as well as the structure of the data the manifest points to.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The UDS+ Test Kit validates the conformance of a server to the [UDS+ IG v2.0.0](https://fhir.org/guides/hrsa/uds-plus/index.html). The included tests function as a rudimentary data receiver. This receiver will take a provided Import Manifest, either as an HTTP location or as a raw json, and validate its contents. This includes validating the structure of the manifest, as well as the structure of the data the manifest points to.
The UDS+ Test Kit validates the conformance of a server to the [UDS+ IG v2.0.0](https://fhir.org/guides/hrsa/uds-plus/STU2). The included tests function as a rudimentary data receiver. This receiver will take a provided Import Manifest, either as an HTTP location or as a raw json, and validate its contents. This includes validating the structure of the manifest, as well as the structure of the data the manifest points to.

A version-stable link should be used here. The existing link points to whatever the current release is rather than always pointing to 2.0.0.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this would be best practice. However, the IG does not provide any version-stable links, so we will have to keep it as-is.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version-stable link is in the suggestion in my comment.

In the IG publication history, you get the stable link by copying the link from the section for the version you want (STU2 Sequence in this case) rather than from the "Current Versions" section.

Screenshot 2025-04-30 at 7 52 27 AM

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Thank you for finding that URL. I've updated all places where an IG link was provided to use that endpoint

@Jammjammjamm Jammjammjamm merged commit bf3ddd7 into inferno-framework:main Apr 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants