-
Notifications
You must be signed in to change notification settings - Fork 951
Comparing changes
Open a pull request
base repository: infinitered/reactotron
base: reactotron-react-native-mmkv@0.2.7
head repository: infinitered/reactotron
compare: master
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0781cac - Browse repository at this point
Copy the full SHA 0781cacView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcf0b85 - Browse repository at this point
Copy the full SHA fcf0b85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e3eeef - Browse repository at this point
Copy the full SHA 4e3eeefView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca510b6 - Browse repository at this point
Copy the full SHA ca510b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8f4512 - Browse repository at this point
Copy the full SHA d8f4512View commit details -
Configuration menu - View commit details
-
Copy full SHA for 018b2e2 - Browse repository at this point
Copy the full SHA 018b2e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb59b32 - Browse repository at this point
Copy the full SHA bb59b32View commit details
Commits on Oct 4, 2024
-
fix(example-app): remove react-native-reanimated (#1509 by @frankcalise)
[skip ci] ## Describe your PR - Removes `react-native-reanimated` dependency from the Example App - Simplifies the Example App for easier contributions (in the terms of, it's less of a headache to build, see Why) - Tested building Android, switching between old and new arch without any hiccups or patching that @morganick has begun to push upstream ## Why - It's been trouble in a monorepo setting - We don't use it in the example app, it was just from Ignite spin up
Configuration menu - View commit details
-
Copy full SHA for 1f05c7c - Browse repository at this point
Copy the full SHA 1f05c7cView commit details -
fix(reactotron-react-native): new arch support (#1508 by @frankcalise)
## Describe your PR - Closes #1486 - `NativeModules` aren't available in bridgeless, so we utilize the `TurboModuleRegistry` to dig up the same calls we were using (this is backwards compatible) - [ ] Maybe want to do better TSing over `eslint-disable` but I'll leave that up to @morganick's review 😅 > [!WARNING] > The `DevMenu` change is not Expo Go compatible. This will never work in Expo Go as documented in infinitered/ignite#2678. This would only impact the client devtools code, which they could remove the custom command from the Reactotron configuration (in this repo, it's just in the example app, hence the CNG change) ```bash ERROR Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'DevMenu' could not be found. Verify that a module by this name is registered in the native binary.Bridgeless mode: false. TurboModule interop: false. Modules loaded: {"NativeModules":["PlatformConstants","LogBox","BlobModule","PlatformConstants","SourceCode","PlatformConstants","DeviceInfo"],"TurboModules":[],"NotFound":["DevMenu"]}, js engine: hermes ```
Configuration menu - View commit details
-
Copy full SHA for c114e09 - Browse repository at this point
Copy the full SHA c114e09View commit details -
Configuration menu - View commit details
-
Copy full SHA for db2e5ec - Browse repository at this point
Copy the full SHA db2e5ecView commit details
Commits on Oct 17, 2024
-
fix(reactotron-app): proper separators in view menu (#1492 by @DIntri…
…glia) ## Please verify the following: - [X] `yarn build-and-test:local` passes - [X] I have added tests for any new features, if relevant - [X] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR This updates the menu to use a type of separator instead of the whitespace at the bottom of the View menu. It is also updated for developer mode to not have a space at the bottom when not developer mode. Co-authored-by: Dakotah Intriglia <dakotah.intriglia@evernorth.com>
Configuration menu - View commit details
-
Copy full SHA for 39893d8 - Browse repository at this point
Copy the full SHA 39893d8View commit details -
fix(reactotron-app): Timeline empty state improvements (#1395 by @car…
…linisaacson) #1359 - Timeline empty state improvements - Adds a button for the quick start guide - Adds a random developer joke Contributors: @carlinisaacson @trevor-coleman @darinwilson  --------- Co-authored-by: Frank Calise <fcalise@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f1472d7 - Browse repository at this point
Copy the full SHA f1472d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a6b6fc - Browse repository at this point
Copy the full SHA 9a6b6fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5caef27 - Browse repository at this point
Copy the full SHA 5caef27View commit details
Commits on Oct 18, 2024
-
fix(.circleci): electronuserland/builder:20-wine (#1514)
## Please verify the following: - [x] `yarn build-and-test:local` passes - [x] I have added tests for any new features, if relevant - [x] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR This PR to fix this [CircleCI failure](https://app.circleci.com/pipelines/github/infinitered/reactotron/2478/workflows/f652a467-1905-4cce-b184-35ade28a2c01/jobs/3326) by updating the docker image to a [more recent tag](https://hub.docker.com/r/electronuserland/builder/tags). The reason why it was failing is that the docker image [electronuserland/builder:16-wine](https://hub.docker.com/layers/electronuserland/builder/16-wine/images/sha256-87efa4ff09eabc913094942a4f48d02ff6f27597155adef3f23fcc948106541b?context=explore) uses node 16, which yarn 4 is no longer compatable. Bumping the docker image to [electronuserland/builder:20-wine](https://hub.docker.com/layers/electronuserland/builder/20-wine/images/sha256-d33a2fd3b3a86c773fec534df9cf215038180779303c6019a2964650e27e58d7?context=explore) makes use of Node 20. This separate docker image is needed to compile the Reactotron Electron app on Windows. The default node orb appears to use [lts by default](https://circleci.com/developer/orbs/orb/circleci/node?version=5.2.0#executors-default), so that is likely why it hasn't been failing since it isn't pinned.
Configuration menu - View commit details
-
Copy full SHA for 9312864 - Browse repository at this point
Copy the full SHA 9312864View commit details
Commits on Oct 28, 2024
-
ci: add scripts for trusting PRs from forks to allow CI to run (#1512)
## Please verify the following: - [x] `yarn build-and-test:local` passes - [x] I have added tests for any new features, if relevant - [x] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR ### Summary * adds the `ci:trust` script and related docs. to the local repo * CircleCI Changes: * add the "trust-check" step, to ensure CI doesn't run on untrusted forks * Adds github workflows to: * push PR changes to a trusted branch then clean up automatically after 2h * delete all temp trusted branches with matching branch names ### Notes: * Based on [this article](https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/), this config prevents the build-docs action from running on untrusted forks. * CI will check if a branch is trusted before running CI * Once a branch is trusted, then CI will run * The github workflow to create a temp branch will automatically clean up the branch after a couple hours, and a separate action is provided to manually delete all temp branches in case any get left behind. * the `ci:trust` script will need to be cleaned up manually for now -- can maybe automate that with a cron job in github workflows --------- Co-authored-by: Joshua Yoes <37849890+joshuayoes@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b5fbdb6 - Browse repository at this point
Copy the full SHA b5fbdb6View commit details -
docs: resolve image and warning formating (#1518)
## Please verify the following: - [x] `yarn build-and-test:local` passes - [x] I have added tests for any new features, if relevant - [x] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR This PR resolves some image formatting issues in the Reactotron docs: https://docs.infinite.red/reactotron/contributing/architecture/ ### Before <img width="1362" alt="Screenshot 2024-10-28 at 11 35 43 AM" src="https://github.com/user-attachments/assets/ed98c989-2d89-4f7c-99cd-2c978eb7bd6b"> <img width="1359" alt="Screenshot 2024-10-28 at 11 34 09 AM" src="https://github.com/user-attachments/assets/951ccf46-ccca-44f5-9cf6-d62fb318b2f1"> ### After <img width="1355" alt="Screenshot 2024-10-28 at 11 34 54 AM" src="https://github.com/user-attachments/assets/e7c49a04-73dd-4372-a836-ef20ce803888"> <img width="1529" alt="Screenshot 2024-10-28 at 11 35 30 AM" src="https://github.com/user-attachments/assets/266ccb12-bbff-4453-9f9b-e0c52fb19b24">
Configuration menu - View commit details
-
Copy full SHA for 4ed6195 - Browse repository at this point
Copy the full SHA 4ed6195View commit details
Commits on Oct 29, 2024
-
fix: enable strict mode for TS types (#1466)
## Please verify the following: - [x] `yarn build-and-test:local` passes - [x] I have added tests for any new features, if relevant - [x] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR This PR enables strict mode for the `reactotron-core-client` codebase to fix issues documented here: #1430
Configuration menu - View commit details
-
Copy full SHA for fd8cf47 - Browse repository at this point
Copy the full SHA fd8cf47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73bc5bc - Browse repository at this point
Copy the full SHA 73bc5bcView commit details
Commits on Oct 30, 2024
-
fix: BigInts on hermes android were crashing during serialization for…
… reactotron (#1498 by @markrickert) ## Please verify the following: - [x] `yarn build-and-test:local` passes - [x] I have added tests for any new features, if relevant - [x] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR I though I had fixed this but we got more reports from the community that it was still broken on android. I added a few new buttons to the example app and was able to reproduce the crash on my android emulator on expo 50 / rn 0.73.6. With these changes, bigints show up properly in the reactotron app. Closes #1436  Co-authored-by: Frank Calise <fcalise@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b64afb - Browse repository at this point
Copy the full SHA 3b64afbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dd49e2 - Browse repository at this point
Copy the full SHA 3dd49e2View commit details
Commits on Nov 4, 2024
-
Fix: Handling console.log(null) (#1520)
## Please verify the following: - [x] `yarn build-and-test:local` passes - [ ] ~I have added tests for any new features, if relevant!~ - [ ] ~`README.md` (or relevant documentation) has been updated with your changes~ ## Describe your PR Fixes #1517 where calling `console.log` with `null` resulted in a blank screen. Now the comments around the function say that it only handles `string`, `object`, `number`, and `boolean`; however, the function takes a `message` of type `any`. Seems like we could narrow that down a bit. I've checked with all of the possible return values for `typeof` and documented that in the code. The reason the bug existed is because `typeof null` results in `object`. The code -- nor many people-- were expecting that. Here's the reference to the docs as to why: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/typeof#typeof_null It appears that we do some things to not return functions as strings and we don't handle `Symbol`. Not sure if that's a requirement based on what the comments around the function say that it should accept as a message type.
⚠️ I'm not sure why the `getPreview` function returned just the raw message if we didn't discern what type it was. That seems like a bug. If someone has context as to why that was the case, I'd love to understand why. ## Screenshot This is what it looks like now: <img width="598" alt="image" src="https://github.com/user-attachments/assets/93c937eb-04bb-47c1-a219-1c751379924f"> Here's another case where we didn't handle `null` correctly and now we do: <img width="775" alt="image" src="https://github.com/user-attachments/assets/83184221-0a79-407d-80cf-2aaefa7d5e55"> Happy Debugging 😎Configuration menu - View commit details
-
Copy full SHA for 98e4805 - Browse repository at this point
Copy the full SHA 98e4805View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2786c0b - Browse repository at this point
Copy the full SHA 2786c0bView commit details
Commits on Nov 14, 2024
-
fix: Removing react-native-flipper (#1524)
## Please verify the following: - [x] `yarn build-and-test:local` passes - [ ] I have added tests for any new features, if relevant - [ ] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR Removing Flipper support. Fixes #1333
Configuration menu - View commit details
-
Copy full SHA for b1e7022 - Browse repository at this point
Copy the full SHA b1e7022View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8ea385 - Browse repository at this point
Copy the full SHA e8ea385View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed7c16e - Browse repository at this point
Copy the full SHA ed7c16eView commit details
Commits on Dec 23, 2024
-
fix(reactotron-react-native): only set DevMenu when in __DEV__ (#1527 …
…by @frankcalise and @joshuayoes) ## Please verify the following: - [x] `yarn build-and-test:local` passes - [ ] I have added tests for any new features, if relevant - [ ] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR - Closes #1513 - Before we improperly included the DevMenu module in both debug and release builds, this checks the `__DEV__` flag - Now we access the module using `TurboModuleRegistry.get` instead of `TurboModuleRegistry.getEnforcing` to avoid throwing a top level JS error when it does not exist --------- Co-authored-by: Joshua Yoes <37849890+joshuayoes@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5f692ac - Browse repository at this point
Copy the full SHA 5f692acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e8fe92 - Browse repository at this point
Copy the full SHA 7e8fe92View commit details
Commits on Jan 7, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 47be69f - Browse repository at this point
Copy the full SHA 47be69fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8236bee - Browse repository at this point
Copy the full SHA 8236beeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6d7810 - Browse repository at this point
Copy the full SHA a6d7810View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9eb17d - Browse repository at this point
Copy the full SHA b9eb17dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68d3214 - Browse repository at this point
Copy the full SHA 68d3214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 192d5ce - Browse repository at this point
Copy the full SHA 192d5ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03710f7 - Browse repository at this point
Copy the full SHA 03710f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed994d5 - Browse repository at this point
Copy the full SHA ed994d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37be71f - Browse repository at this point
Copy the full SHA 37be71fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1481a2 - Browse repository at this point
Copy the full SHA a1481a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 307fab1 - Browse repository at this point
Copy the full SHA 307fab1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe623a6 - Browse repository at this point
Copy the full SHA fe623a6View commit details
Commits on Jan 28, 2025
-
feat: show graphql operation name for graphql requests (#1521 by @yur…
…ik256) ## Please verify the following: - [x] `yarn build-and-test:local` passes - [x] I have added tests for any new features, if relevant - [x] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR On the react native project I'm working on, we are extensively using graphql. Current implement of timeline plugin, makes it hard to differentiate graphql requests, as they are all shown as `POST /graphql` in the timeline This PR improves this by adding the following * show operation name for graphql requests * This is implemented by parsing `request.operationName` field, which is automatically added for all graphql requests made by `@apollo/client` * Ability to filter requests by request data **Screenshots** Show operation name  Ability to search by request data ( in this case, operation name )  --------- Co-authored-by: Nick Morgan <morganick@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 21b9759 - Browse repository at this point
Copy the full SHA 21b9759View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9df3cb1 - Browse repository at this point
Copy the full SHA 9df3cb1View commit details
Commits on Feb 3, 2025
-
chore(reactotron-app): refactor electron-store to match docs (#1536)
## Please verify the following: - [x] `yarn build-and-test:local` passes ## Describe your PR This PR does a minor refactor to our electron-store usage to trigger a release for reactotron-app, to release this PR #1521
Configuration menu - View commit details
-
Copy full SHA for cac1f29 - Browse repository at this point
Copy the full SHA cac1f29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a59950 - Browse repository at this point
Copy the full SHA 3a59950View commit details
Commits on Feb 7, 2025
-
docs(redux): update enhancers with proper example code (#1511 by @fra…
…nkcalise) ## Please verify the following: - [ ] `yarn build-and-test:local` passes - [ ] I have added tests for any new features, if relevant - [ ] `README.md` (or relevant documentation) has been updated with your changes ## Describe your PR - Closes #1450 with updated documentation - Updates docs with the redux code we provide in the `example-app`
Configuration menu - View commit details
-
Copy full SHA for 8ec0e10 - Browse repository at this point
Copy the full SHA 8ec0e10View commit details
Commits on Feb 12, 2025
-
chore(.circleci/config.yml): electronuserland/builder:20-wine-07.24 (#…
…1540) ## Please verify the following: - [x] `yarn build-and-test:local` passes ## Describe your PR [This job passed with the same docker image tag](https://app.circleci.com/pipelines/github/infinitered/reactotron/2519/workflows/437dbf3c-a838-49b1-b7a9-59e7df52137d/jobs/3423) a few months ago. It appears the [electron-builder](https://www.electron.build/multi-platform-build.html#provided-docker-images) docs encourage pinning specific versions for this situation, because it appears the [image tag has changed in the latest run that failed](https://app.circleci.com/pipelines/github/infinitered/reactotron/2558/workflows/5c710dfe-c28b-47f9-b693-f5c59a6327c0/jobs/3499). This PR attempt to address this by [pinning the docker image tag to a timestamped one](https://hubgw.docker.com/layers/electronuserland/builder/20-wine-07.24/images/sha256-d33a2fd3b3a86c773fec534df9cf215038180779303c6019a2964650e27e58d7) that will never change. I confirmed that this is a CI issue by trying to do the build on my local windows machine and it passed.
Configuration menu - View commit details
-
Copy full SHA for eed7097 - Browse repository at this point
Copy the full SHA eed7097View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6838133 - Browse repository at this point
Copy the full SHA 6838133View commit details
Commits on Mar 1, 2025
-
chore(scripts): add release notes (#1543 by @joshuayoes)
This PR modifies the `release.artifacts.mjs` release scripts to parse the local `CHANGELOG.md` files changes, if they are relevant to a release --------- Co-authored-by: Jamon Holmgren <code@jamon.dev>
Configuration menu - View commit details
-
Copy full SHA for 8cbac0b - Browse repository at this point
Copy the full SHA 8cbac0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for debb6b9 - Browse repository at this point
Copy the full SHA debb6b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d60052 - Browse repository at this point
Copy the full SHA 9d60052View commit details
There are no files selected for viewing