Skip to content

Commit 442dd4f

Browse files
committed
Fix Corepack issues in Playwright image
1 parent 84d156d commit 442dd4f

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

.github/actions/node-setup/action.yml

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,35 @@ inputs:
55
install-dependencies:
66
description: 'Set to false to skip pnpm install (for tooling-only jobs)'
77
default: 'true'
8+
enable-corepack:
9+
description: 'Enable corepack; set false to skip and npm-install pnpm'
10+
default: 'true'
11+
pnpm-version:
12+
description: 'pnpm version to activate/install'
13+
default: '10.24.0'
814

915
runs:
1016
using: 'composite'
1117
steps:
12-
- name: 🗃️ Enable corepack
13-
run: corepack enable
14-
shell: bash
15-
1618
- name: 🎰 Setup Node
1719
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
1820
with:
1921
node-version-file: 'package.json'
2022
cache: 'pnpm'
2123
cache-dependency-path: 'pnpm-lock.yaml'
2224

25+
- name: 🗃️ Enable corepack
26+
if: inputs.enable-corepack == 'true'
27+
run: |
28+
corepack enable
29+
corepack prepare pnpm@${{ inputs.pnpm-version }} --activate
30+
shell: bash
31+
32+
- name: 📦 Install pnpm via npm (corepack disabled)
33+
if: inputs.enable-corepack != 'true'
34+
run: npm install -g pnpm@${{ inputs.pnpm-version }}
35+
shell: bash
36+
2337
- name: 📥 Install dependencies
2438
if: inputs.install-dependencies == 'true'
2539
run: pnpm install --frozen-lockfile --prefer-offline --ignore-scripts

.github/workflows/e2e.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ jobs:
3737
3838
- name: 💻 Node setup
3939
uses: ./.github/actions/node-setup
40+
with:
41+
enable-corepack: 'false'
4042

4143
- name: 🎭 E2E setup
4244
uses: ./.github/actions/e2e-setup

0 commit comments

Comments
 (0)