Skip to content

Conversation

@ante-kadic
Copy link

Added new chapter for .NET Aspire

@andrejVuk7
Copy link
Contributor

Can you please change the target branch to "staging"? After it passes the verification in the Staging environment, we can merge it to the master branch.

Copy link
Contributor

@andrejVuk7 andrejVuk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall! I left a couple of structural, syntax and rewording suggestions, but the content looks OK to me. I would also like to suggest running this through Grammarly, if you haven't done it so far.

@andrejVuk7
Copy link
Contributor

One more comment that I just came up with - what do you think about expanding the analysis of this tool a bit to include some things like possible disadvantages, pitfalls to avoid and best practices based on our experience (if we can provide that at the moment)? We may also add some images depicting the example structure of an Aspire project to better see how the two projects mentioned in the text are blending into the overall solution.

P.S. This can be added in a different PR and we may discuss adding some code to the Example project if that's possible.

@ante-kadic ante-kadic changed the base branch from master to staging September 22, 2025 09:13
@ante-kadic
Copy link
Author

One more comment that I just came up with - what do you think about expanding the analysis of this tool a bit to include some things like possible disadvantages, pitfalls to avoid and best practices based on our experience (if we can provide that at the moment)? We may also add some images depicting the example structure of an Aspire project to better see how the two projects mentioned in the text are blending into the overall solution.

P.S. This can be added in a different PR and we may discuss adding some code to the Example project if that's possible.

I've added limitations and possible pitfalls to avoid. Not sure about the best practices from our experience since we don't have much hands on experience ATM (if any). We can add that later on with new PR. Btw, we do have example project in our examples repo.

@ante-kadic ante-kadic merged commit 58a12a9 into staging Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants