-
Notifications
You must be signed in to change notification settings - Fork 1
.NET Aspire chapter #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Aspire chapter #119
Conversation
…l as an explanation what a status should be used
A chapter about health checks
Pushing the changes from Staging to Production
|
Can you please change the target branch to "staging"? After it passes the verification in the Staging environment, we can merge it to the master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job overall! I left a couple of structural, syntax and rewording suggestions, but the content looks OK to me. I would also like to suggest running this through Grammarly, if you haven't done it so far.
|
One more comment that I just came up with - what do you think about expanding the analysis of this tool a bit to include some things like possible disadvantages, pitfalls to avoid and best practices based on our experience (if we can provide that at the moment)? We may also add some images depicting the example structure of an Aspire project to better see how the two projects mentioned in the text are blending into the overall solution. P.S. This can be added in a different PR and we may discuss adding some code to the Example project if that's possible. |
I've added limitations and possible pitfalls to avoid. Not sure about the best practices from our experience since we don't have much hands on experience ATM (if any). We can add that later on with new PR. Btw, we do have example project in our examples repo. |
Added new chapter for .NET Aspire