Replace hr with de locale in localization specs

Author: djordjelacmanovic

spec/dummy/config/initializers/i18n.rb

@@ -1,3 +1,3 @@
-I18n.available_locales = [:en, :hr]
+I18n.available_locales = [:en, :de]
 
 I18n.default_locale = :en

spec/dummy/config/locales/de.yml

@@ -0,0 +1,4 @@
+de:
+  hello: "Hallo Welt"
+
+

spec/dummy/config/locales/hr.yml

@@ -0,0 +1,24 @@
+de:
+  json_api:
+    errors:
+      bad_request:
+        title: Ungültige Anfrage
+        detail: Ungültige Anfrage
+        invalid_locale: Ungültige Sprache
+      not_found:
+        title: Nicht gefunden
+        detail: Ressource nicht gefunden
+      forbidden:
+        title: Verboten
+        detail: Sie dürfen diese Aktion nicht ausführen
+      unauthorized:
+        title: Nicht autorisiert
+        detail: Sie müssen angemeldet sein, um diese Aktion auszuführen
+      unprocessable_entity:
+        title: Nicht verarbeitbar
+        detail: Anfrage kann nicht verarbeitet werden
+      internal_server_error:
+        title: Interner Fehler
+        detail: Ein interner Fehler ist aufgetreten
+
+

spec/dummy/config/locales/json_api.de.yml

@@ -35,11 +35,11 @@
 
     context 'with another locale' do
       it 'responds with localized error message' do
-        get '/api/v1/locations/0', headers: default_headers.merge('Accept-Language' => 'hr')
+        get '/api/v1/locations/0', headers: default_headers.merge('Accept-Language' => 'de')
 
         expect(response).to have_http_status(:not_found)
-        expect(json_response['errors'].first['title']).to eq('Nije pronađen')
-        expect(json_response['errors'].first['detail']).to eq('Resurs nije pronađen')
+        expect(json_response['errors'].first['title']).to eq('Nicht gefunden')
+        expect(json_response['errors'].first['detail']).to eq('Ressource nicht gefunden')
       end
     end
   end
@@ -58,11 +58,11 @@
 
     context 'with another locale' do
       it 'responds with localized error message' do
-        get "/api/v1/locations/#{loc.id}", headers: default_headers.merge('Accept-Language' => 'hr')
+        get "/api/v1/locations/#{loc.id}", headers: default_headers.merge('Accept-Language' => 'de')
 
         expect(response).to have_http_status(:forbidden)
-        expect(json_response['errors'].first['title']).to eq('Zabranjeno')
-        expect(json_response['errors'].first['detail']).to eq('Nije Vam dozvoljeno izvršiti ovu radnju')
+        expect(json_response['errors'].first['title']).to eq('Verboten')
+        expect(json_response['errors'].first['detail']).to eq('Sie dürfen diese Aktion nicht ausführen')
       end
     end
   end

spec/requests/api/v1/error_handling_spec.rb

@@ -5,44 +5,39 @@
 
       expect(response).to have_http_status(:ok)
 
-      response_body = JSON.parse(response.body)
-      expect(response_body['data']['attributes']['message']).to eq('Hello world')
+      expect(json_response['data']['attributes']['message']).to eq('Hello world')
     end
 
-    it 'returns Croatian hello message when Accept-Language is hr' do
-      get '/api/v1/hello', headers: default_headers.merge('Accept-Language': 'hr')
+    it 'returns German hello message when Accept-Language is de' do
+      get '/api/v1/hello', headers: default_headers.merge('Accept-Language': 'de')
 
       expect(response).to have_http_status(:ok)
 
-      response_body = JSON.parse(response.body)
-      expect(response_body['data']['attributes']['message']).to eq('Pozdrav svijetu')
+      expect(json_response['data']['attributes']['message']).to eq('Hallo Welt')
     end
 
-    it 'returns Croatian hello message when Accept-Language is hr-HR (region variant)' do
-      get '/api/v1/hello', headers: default_headers.merge('Accept-Language': 'hr-HR')
+    it 'returns German hello message when Accept-Language is de-DE (region variant)' do
+      get '/api/v1/hello', headers: default_headers.merge('Accept-Language': 'de-DE')
 
       expect(response).to have_http_status(:ok)
 
-      response_body = JSON.parse(response.body)
-      expect(response_body['data']['attributes']['message']).to eq('Pozdrav svijetu')
+      expect(json_response['data']['attributes']['message']).to eq('Hallo Welt')
     end
 
     it 'returns default English message when no Accept-Language header provided' do
       get '/api/v1/hello', headers: default_headers
 
       expect(response).to have_http_status(:ok)
 
-      response_body = JSON.parse(response.body)
-      expect(response_body['data']['attributes']['message']).to eq('Hello world')
+      expect(json_response['data']['attributes']['message']).to eq('Hello world')
     end
 
     it 'prioritizes first valid locale from complex Accept-Language header' do
-      get '/api/v1/hello', headers: default_headers.merge('Accept-Language': 'hr-HR,hr;q=0.9,en;q=0.8')
+      get '/api/v1/hello', headers: default_headers.merge('Accept-Language': 'de-DE,de;q=0.9,en;q=0.8')
 
       expect(response).to have_http_status(:ok)
 
-      response_body = JSON.parse(response.body)
-      expect(response_body['data']['attributes']['message']).to eq('Pozdrav svijetu')
+      expect(json_response['data']['attributes']['message']).to eq('Hallo Welt')
     end
 
     it 'falls back to default locale when Accept-Language header is malformed' do
@@ -57,10 +52,10 @@
 
   describe 'error handling with localized messages' do
     it 'responds with 400 Bad Request and English error message for invalid locale' do
-      get '/api/v1/hello', headers: default_headers.merge('Accept-Language': 'de')
+      get '/api/v1/hello', headers: default_headers.merge('Accept-Language': 'fr')
 
       expect(response).to have_http_status(:bad_request)
-      expect(response).to include_error_detail('"de" is not a valid locale')
+      expect(response).to include_error_detail('"fr" is not a valid locale')
     end
   end
 end