-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation errors should not shift input fields #232
Comments
I can make this work for if there is only error message. but if there are both error message And help message, I'm not sure I can make the spacing work because of how absolute positioning works with css. But I could be completely wrong here. options:
Thoughts ? @mavarius |
I took a look at how other design systems handle this, Material UI has it so that the helper text does both normal state helper message and error message. The error state toggle just changes the color and messaging of the helper text. Carbon has it so that the error message take up space when it appears and shifts everything below. I like the idea of the error message not shifting things just as this issue points out so maybe we could emulate the material uI pattern? |
Let's go with the error message replacing the helper text. |
close this until a specific input field is referenced. |
Describe the bug
When error messages appear below input fields, everything below them shifts.
Expected behavior
The layout of the form should remain static when validation errors are present.
The text was updated successfully, but these errors were encountered: