-
Notifications
You must be signed in to change notification settings - Fork 132
[IMP] account_internal_transfer: transfer entries in company currency #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cav-adhoc
wants to merge
3
commits into
ingadhoc:19.0
Choose a base branch
from
adhoc-dev:19.0-t-58355-cav
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+164
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
842d172 to
eb61be4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Este PR corrige el comportamiento de las transferencias internas entre journals con diferentes monedas, asegurando que los importes se registren correctamente en la moneda de la compañía para el journal con moneda principal.
Cambios clave:
- Se añade el método
_prepare_move_line_default_valspara ajustar los importes de las líneas de movimiento contable - Se implementa lógica para convertir
amount_currencya la moneda de la compañía cuando el journal destino usa una moneda diferente
f2b9e64 to
97da4b7
Compare
In a transfer between a journal in main currency and one in secondary currency, the amount field in the journal entry for the main currency journal must be adjusted so it is recorded in the main currency, not in the secondary currency. This commit fixes that behavior.
d6dd311 to
7dd3103
Compare
…warnings Improve the user experience when managing internal transfer payments: * Auto-synchronize paired payments: When updating amount or journals on one payment, automatically propagate changes to its paired payment to maintain consistency between both sides of the transfer * State mismatch warning: Display an alert when paired payments are in different states, showing both current states and prompting users to synchronize them before completing changes * Quick navigation: Add a "Go to Paired Payment" button directly in the warning message for easy access to the related payment Technical improvements: - Override write() method with recursion prevention via context flag - Add computed HTML field for dynamic warning display - Add action method for navigation between paired payments - Update form view to display warnings before sheet content
7dd3103 to
82e8657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

In a transfer between a journal in main currency and one in secondary currency, the amount field in the journal entry for the main currency journal must be adjusted so it is recorded in the main currency, not in the secondary currency. This commit fixes that behavior.