feat(wallet): add optional pollController$ dependency LW-12174 #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to control polling. Should emit: - `true` to switch on polling - `false` to switch off polling
AngelCastilloB
approved these changes
Jan 28, 2025
Member
AngelCastilloB
left a comment
AngelCastilloB
left a comment
There was a problem hiding this comment.
Nice and simple solution @mkazlauskas 🧙🏼
mirceahasegan
approved these changes
Jan 28, 2025
Collaborator
mirceahasegan
left a comment
mirceahasegan
left a comment
There was a problem hiding this comment.
Great work @mkazlauskas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See LW-12174
Proposed Solution
See commit b75b9dc
Tested in Lace, seems to work well
Important Changes Introduced