Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

Description

Added missing Hash trait impl for Cip0134Uri type.
Bumped cardano-blockchain-types crate for new release.

Related Pull Requests

#631

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy self-assigned this Nov 13, 2025
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Nov 13, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Nov 13, 2025
@Mr-Leshiy Mr-Leshiy requested a review from apskhem November 13, 2025 09:24
apskhem
apskhem previously approved these changes Nov 13, 2025
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy dismissed stale reviews from stanislav-tkach and apskhem via c88c376 November 13, 2025 10:27
@github-actions
Copy link
Contributor

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/cip-134-uri-hash

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 554/554}$ | ${\color{red}Fail: 0/554}$ |

@Mr-Leshiy Mr-Leshiy merged commit fe42df6 into main Nov 13, 2025
23 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/cip-134-uri-hash branch November 13, 2025 10:51
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants