fix: TypeError in agent announcement process

- Add type check in fsm.py to ensure payload is a dictionary before passing to set_from
- Add defensive check in host.py to verify required keys exist in announce response
- Prevents "'bool' object is not subscriptable" error in confluent_kafka tests

Signed-off-by: Paulo Vital <[email protected]>

Author: pvital

src/instana/agent/host.py

@@ -138,10 +138,15 @@ def set_from(
         @return: None
         """
         self.options.set_from(res_data)
-        self.announce_data = AnnounceData(
-            pid=res_data["pid"],
-            agentUuid=res_data["agentUuid"],
-        )
+
+        # Ensure required keys are present
+        if "pid" in res_data and "agentUuid" in res_data:
+            self.announce_data = AnnounceData(
+                pid=res_data["pid"],
+                agentUuid=res_data["agentUuid"],
+            )
+        else:
+            logger.debug(f"Missing required keys in announce response: {res_data}")
 
     def get_from_structure(self) -> Dict[str, str]:
         """

src/instana/fsm.py

@@ -148,7 +148,7 @@ def announce_sensor(self, e: Any) -> bool:
 
         payload = self.agent.announce(d)
 
-        if not payload:
+        if not payload or not isinstance(payload, dict):
             logger.debug("Cannot announce sensor. Scheduling retry.")
             self.schedule_retry(
                 self.announce_sensor, e, f"{self.THREAD_NAME}: announce"

tests/agent/test_host.py

@@ -5,7 +5,7 @@
 import json
 import logging
 import os
-from typing import Generator
+from typing import Any, Dict, Generator
 from unittest.mock import Mock
 
 import pytest
@@ -717,3 +717,36 @@ def test_is_service_or_endpoint_ignored(self) -> None:
         # don't ignore other services
         assert not self.agent._HostAgent__is_endpoint_ignored("service3")
         assert not self.agent._HostAgent__is_endpoint_ignored("service3")
+
+    @pytest.mark.parametrize(
+        "input_data",
+        [
+            {
+                "agentUuid": "test-uuid",
+            },
+            {
+                "pid": 1234,
+            },
+            {
+                "extraHeaders": ["value-3"],
+            },
+        ],
+        ids=["missing_pid", "missing_agent_uuid", "missing_both_required_keys"],
+    )
+    def test_set_from_missing_required_keys(
+        self, input_data: Dict[str, Any], caplog: pytest.LogCaptureFixture
+    ) -> None:
+        """Test set_from when required keys are missing in res_data."""
+        agent = HostAgent()
+        caplog.set_level(logging.DEBUG, logger="instana")
+
+        res_data = {
+            "secrets": {"matcher": "value-1", "list": ["value-2"]},
+        }
+        res_data.update(input_data)
+
+        agent.set_from(res_data)
+
+        assert agent.announce_data is None
+        assert "Missing required keys in announce response" in caplog.messages[-1]
+        assert str(res_data) in caplog.messages[-1]