[BUG]: Breaking change introduced with no documentation in 6.10.0 (allowed_merge_methods)

[kpocius]

Expected Behavior

Bump provider to 6.10.0 -- since no breaking changes are recorded in release notes, it should just work.

Actual Behavior

Plan fails:

│ Error: Missing required argument
│ 
│   on modules/repository/main.tf line 79, in resource "github_repository_ruleset" "default":
│   79:     pull_request {
│ 
│ The argument "allowed_merge_methods" is required, but no definition was
│ found.

Terraform Version

Terraform v1.10.5
on darwin_arm64

• provider registry.terraform.io/integrations/github v6.10.0

Affected Resource(s)

github_repository_ruleset

Terraform Configuration Files

Steps to Reproduce

The issue got introduced in #2976 because allowed_merge_methods is required, but it's not even documented in https://registry.terraform.io/providers/integrations/github/latest/docs/resources/repository_ruleset so you can only infer the values from reading the code.

Debug Output

Panic Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[deiga]

Hey 👋
This would be my fault. I forgot to add docs for it.
BUT AFAIK it shouldn't have been working without this field since the API started requiring that field.
Can you confirm if the same config worked for you on 6.9.0?

FUDGE 🤦
Sorry, I must have misread the API changes

[kpocius]

Beggars can't be choosers 🙈 I'll be happy to help any way I can, but indeed looks like it's a breaking change as is.

[youvegotmoxie]

Thanks Renovatebot 🙃

Error: Missing required argument
╷
│ Error: Missing required argument
│ 
│   on ../../modules/repo/main.tf line 131, in resource "github_repository_ruleset" "require_pull_request_master":
│  131:     pull_request {
│ 
│ The argument "allowed_merge_methods" is required, but no definition was
│ found.

[deiga]

I'm so sorry for the hassle! We got v6.10.1 released which fixes the issue

[youvegotmoxie]

It happens, thanks for the quick turnaround!