Fix typo and error check when retrieving pci information

Fix
1. typo PhysialDevicePciSpeedInfo to PhysicalDevicePciSpeedInfo
2. error check to verify open() call

Signed-off-by: Joshua Santosh Ranjan <[email protected]>

Author: joshuaranjan

level_zero/core/test/unit_tests/sources/device/linux/test_device_pci_speed_info_linux.cpp

@@ -14,7 +14,7 @@
 namespace L0 {
 namespace ult {
 
-void PciSpeedInfoTest::setPciSpeedInfo(NEO::ExecutionEnvironment *executionEnvironment, const NEO::PhyicalDevicePciSpeedInfo &pciSpeedInfo) {
+void PciSpeedInfoTest::setPciSpeedInfo(NEO::ExecutionEnvironment *executionEnvironment, const NEO::PhysicalDevicePciSpeedInfo &pciSpeedInfo) {
     auto driverModel = std::make_unique<NEO::MockDriverModel>();
     driverModel->pciSpeedInfo = pciSpeedInfo;
     driverModel->pciBusInfo = {0, 1, 2, 3};

level_zero/core/test/unit_tests/sources/device/test_device_pci_speed_info.cpp

@@ -18,7 +18,7 @@
 namespace L0 {
 namespace ult {
 
-std::unique_ptr<NEO::UltDeviceFactory> PciSpeedInfoTest::createDevices(uint32_t numSubDevices, const NEO::PhyicalDevicePciSpeedInfo &pciSpeedInfo) {
+std::unique_ptr<NEO::UltDeviceFactory> PciSpeedInfoTest::createDevices(uint32_t numSubDevices, const NEO::PhysicalDevicePciSpeedInfo &pciSpeedInfo) {
 
     DebugManager.flags.CreateMultipleSubDevices.set(numSubDevices);
     DebugManager.flags.EnableChipsetUniqueUUID.set(0);
@@ -31,7 +31,7 @@ std::unique_ptr<NEO::UltDeviceFactory> PciSpeedInfoTest::createDevices(uint32_t
 
 TEST_F(PciSpeedInfoTest, givenSuccessfulReadingOfSpeedValuesCorrectValuesAreReturned) {
 
-    NEO::PhyicalDevicePciSpeedInfo expectedSpeedInfo;
+    NEO::PhysicalDevicePciSpeedInfo expectedSpeedInfo;
     expectedSpeedInfo.genVersion = 4;
     expectedSpeedInfo.width = 1024;
     expectedSpeedInfo.maxBandwidth = 4096;

level_zero/core/test/unit_tests/sources/device/test_device_pci_speed_info.h

@@ -12,7 +12,7 @@
 #include "gtest/gtest.h"
 
 namespace NEO {
-struct PhyicalDevicePciSpeedInfo;
+struct PhysicalDevicePciSpeedInfo;
 struct UltDeviceFactory;
 class ExecutionEnvironment;
 } // namespace NEO
@@ -21,11 +21,11 @@ namespace L0 {
 namespace ult {
 
 struct PciSpeedInfoTest : public ::testing::Test {
-    std::unique_ptr<NEO::UltDeviceFactory> createDevices(uint32_t numSubDevices, const NEO::PhyicalDevicePciSpeedInfo &pciSpeedInfo);
+    std::unique_ptr<NEO::UltDeviceFactory> createDevices(uint32_t numSubDevices, const NEO::PhysicalDevicePciSpeedInfo &pciSpeedInfo);
     DebugManagerStateRestore restorer;
 
   private:
-    void setPciSpeedInfo(NEO::ExecutionEnvironment *executionEnvironment, const NEO::PhyicalDevicePciSpeedInfo &pciSpeedInfo);
+    void setPciSpeedInfo(NEO::ExecutionEnvironment *executionEnvironment, const NEO::PhysicalDevicePciSpeedInfo &pciSpeedInfo);
 };
 
 } // namespace ult

level_zero/core/test/unit_tests/sources/device/windows/test_device_pci_speed_info_windows.cpp

@@ -21,21 +21,21 @@ namespace ult {
 class PciSpeedInfoTestDriverModel : public WddmMock {
   public:
     PciSpeedInfoTestDriverModel(RootDeviceEnvironment &rootDeviceEnvironment) : WddmMock(rootDeviceEnvironment) {}
-    void setExpectedPciSpeedInfo(const PhyicalDevicePciSpeedInfo &pciSpeedInfo) {
+    void setExpectedPciSpeedInfo(const PhysicalDevicePciSpeedInfo &pciSpeedInfo) {
         returnedSpeedInfo = pciSpeedInfo;
     }
 
-    PhyicalDevicePciSpeedInfo getPciSpeedInfo() const override {
+    PhysicalDevicePciSpeedInfo getPciSpeedInfo() const override {
         return returnedSpeedInfo;
     }
     PhysicalDevicePciBusInfo getPciBusInfo() const override {
         return NEO::PhysicalDevicePciBusInfo(0, 1, 2, 3);
     }
 
-    PhyicalDevicePciSpeedInfo returnedSpeedInfo = {-1, -1, -1};
+    PhysicalDevicePciSpeedInfo returnedSpeedInfo = {-1, -1, -1};
 };
 
-void PciSpeedInfoTest::setPciSpeedInfo(NEO::ExecutionEnvironment *executionEnvironment, const NEO::PhyicalDevicePciSpeedInfo &pciSpeedInfo) {
+void PciSpeedInfoTest::setPciSpeedInfo(NEO::ExecutionEnvironment *executionEnvironment, const NEO::PhysicalDevicePciSpeedInfo &pciSpeedInfo) {
     executionEnvironment->rootDeviceEnvironments[0]->osInterface->setDriverModel(
         std::make_unique<PciSpeedInfoTestDriverModel>(*executionEnvironment->rootDeviceEnvironments[0]));
     PciSpeedInfoTestDriverModel *driverModel = static_cast<PciSpeedInfoTestDriverModel *>(executionEnvironment->rootDeviceEnvironments[0]->osInterface->getDriverModel());

level_zero/tools/test/unit_tests/sources/sysman/linux/test_sysman.cpp

@@ -433,7 +433,7 @@ class UnknownDriverModel : public DriverModel {
         PhysicalDevicePciBusInfo pciBusInfo(PhysicalDevicePciBusInfo::invalidValue, PhysicalDevicePciBusInfo::invalidValue, PhysicalDevicePciBusInfo::invalidValue, PhysicalDevicePciBusInfo::invalidValue);
         return pciBusInfo;
     }
-    PhyicalDevicePciSpeedInfo getPciSpeedInfo() const override { return {}; }
+    PhysicalDevicePciSpeedInfo getPciSpeedInfo() const override { return {}; }
 
     bool isGpuHangDetected(OsContext &osContext) override {
         return false;

opencl/test/unit_test/execution_environment/execution_environment_tests.cpp

@@ -292,7 +292,7 @@ class DriverModelMock : public DriverModel {
     PhysicalDevicePciBusInfo getPciBusInfo() const override {
         return {};
     }
-    PhyicalDevicePciSpeedInfo getPciSpeedInfo() const override {
+    PhysicalDevicePciSpeedInfo getPciSpeedInfo() const override {
         return {};
     }
 

shared/source/os_interface/driver_info.h

@@ -33,7 +33,7 @@ struct PhysicalDevicePciBusInfo {
     uint32_t pciFunction = invalidValue;
 };
 
-struct PhyicalDevicePciSpeedInfo {
+struct PhysicalDevicePciSpeedInfo {
     static constexpr int32_t unknown = -1;
     int32_t genVersion = unknown;
     int32_t width = unknown;

shared/source/os_interface/linux/drm_neo.cpp

@@ -1485,9 +1485,9 @@ int Drm::createDrmVirtualMemory(uint32_t &drmVmId) {
     return ret;
 }
 
-PhyicalDevicePciSpeedInfo Drm::getPciSpeedInfo() const {
+PhysicalDevicePciSpeedInfo Drm::getPciSpeedInfo() const {
 
-    PhyicalDevicePciSpeedInfo pciSpeedInfo = {};
+    PhysicalDevicePciSpeedInfo pciSpeedInfo = {};
 
     std::string pathPrefix{};
     bool isIntegratedDevice = rootDeviceEnvironment.getHardwareInfo()->capabilityTable.isIntegratedDevice;
@@ -1516,7 +1516,7 @@ PhyicalDevicePciSpeedInfo Drm::getPciSpeedInfo() const {
         linkWidthStream << pathPrefix << fileName;
 
         int fd = NEO::SysCalls::open(linkWidthStream.str().c_str(), O_RDONLY);
-        if (fd == 0) {
+        if (fd < 0) {
             return false;
         }
         ssize_t bytesRead = NEO::SysCalls::pread(fd, readString.data(), readString.size() - 1, 0);

shared/source/os_interface/linux/drm_neo.h

@@ -84,7 +84,7 @@ class Drm : public DriverModel {
     unsigned int getDeviceHandle() const override {
         return 0;
     }
-    PhyicalDevicePciSpeedInfo getPciSpeedInfo() const override;
+    PhysicalDevicePciSpeedInfo getPciSpeedInfo() const override;
     int getExecSoftPin(int &execSoftPin);
     int enableTurboBoost();
     int getEuTotal(int &euTotal);

shared/source/os_interface/os_interface.h

@@ -79,7 +79,7 @@ class DriverModel : public NonCopyableClass {
     }
 
     virtual PhysicalDevicePciBusInfo getPciBusInfo() const = 0;
-    virtual PhyicalDevicePciSpeedInfo getPciSpeedInfo() const = 0;
+    virtual PhysicalDevicePciSpeedInfo getPciSpeedInfo() const = 0;
 
     virtual size_t getMaxMemAllocSize() const {
         return std::numeric_limits<size_t>::max();