fix: correct shared cross device alloc caps for sub devices

in case of single exposed device, if there are subdevice, then
subdevices may access between each other

Related-To: HSD-18042639532

Signed-off-by: Mateusz Jablonski <[email protected]>
Source: 10dc8a5

Author: JablonskiMateusz

level_zero/core/source/device/device_imp.cpp

@@ -838,7 +838,7 @@ ze_result_t DeviceImp::getMemoryAccessProperties(ze_device_memory_access_propert
         static_cast<ze_memory_access_cap_flags_t>(productHelper.getSingleDeviceSharedMemCapabilities(isKmdMigrationAvailable));
 
     auto defaultContext = static_cast<ContextImp *>(getDriverHandle()->getDefaultContext());
-    auto multiDeviceWithSingleRoot = defaultContext->getNumDevices() > 1 && defaultContext->rootDeviceIndices.size() == 1;
+    auto multiDeviceWithSingleRoot = defaultContext->rootDeviceIndices.size() == 1 && (defaultContext->getNumDevices() > 1 || isSubdevice);
 
     pMemAccessProperties->sharedCrossDeviceAllocCapabilities = {};
     if (multiDeviceWithSingleRoot || (isKmdMigrationAvailable &&

level_zero/core/test/unit_tests/sources/device/test_l0_device.cpp

@@ -3081,8 +3081,9 @@ struct MemoryAccessPropertiesSingleExposedDeviceTest : public Test<MultiDeviceFi
         MultiDeviceFixtureHierarchy::setUp();
     }
 };
+
 TEST_F(MemoryAccessPropertiesSingleExposedDeviceTest,
-       givenSingleExposedDevicesWhenCallingGetMemoryAccessPropertiesThenSharedCrossDeviceAccessSupportIsNotExposed) {
+       givenSingleExposedDevicesWhenCallingGetMemoryAccessPropertiesForRootDeviceThenSharedCrossDeviceAccessSupportIsNotExposed) {
     L0::Device *device = driverHandle->devices[0];
     ze_device_memory_access_properties_t properties;
     auto result = device->getMemoryAccessProperties(&properties);
@@ -3092,6 +3093,20 @@ TEST_F(MemoryAccessPropertiesSingleExposedDeviceTest,
     EXPECT_EQ(expectedSharedCrossDeviceAllocCapabilities, properties.sharedCrossDeviceAllocCapabilities);
 }
 
+TEST_F(MemoryAccessPropertiesSingleExposedDeviceTest,
+       givenSingleExposedDevicesWhenCallingGetMemoryAccessPropertiesForSubDeviceThenSharedCrossDeviceAccessSupportIsExposed) {
+    L0::Device *rootDevice = driverHandle->devices[0];
+    auto device = static_cast<L0::DeviceImp *>(rootDevice)->subDevices[0];
+    ze_device_memory_access_properties_t properties;
+    auto result = device->getMemoryAccessProperties(&properties);
+    EXPECT_EQ(ZE_RESULT_SUCCESS, result);
+
+    ze_memory_access_cap_flags_t expectedSharedCrossDeviceAllocCapabilities =
+        ZE_MEMORY_ACCESS_CAP_FLAG_RW | ZE_MEMORY_ACCESS_CAP_FLAG_CONCURRENT |
+        ZE_MEMORY_ACCESS_CAP_FLAG_ATOMIC | ZE_MEMORY_ACCESS_CAP_FLAG_CONCURRENT_ATOMIC;
+    EXPECT_EQ(expectedSharedCrossDeviceAllocCapabilities, properties.sharedCrossDeviceAllocCapabilities);
+}
+
 using MultipleDevicesP2PDevice0Access0Atomic0Device1Access0Atomic0Test = MultipleDevicesP2PFixture<0, 0>;
 TEST_F(MultipleDevicesP2PDevice0Access0Atomic0Device1Access0Atomic0Test, WhenCallingGetP2PPropertiesWithBothDevicesHavingNoAccessSupportThenNoSupportIsReturned) {
     L0::Device *device0 = driverHandle->devices[0];