-
Notifications
You must be signed in to change notification settings - Fork 550
feat: No Scan SOC for language parsers #5143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joydeep049
wants to merge
10
commits into
intel:main
Choose a base branch
from
joydeep049:language-parser-SOC
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
Signed-off-by: joydeep049 <[email protected]>
=================================== FAILURES ===================================
_____________________ TestSourceOSV.test_update_ecosystems _____________________
self = <test.test_source_osv.TestSourceOSV object at 0x7fc350c791d0>
@pytest.mark.asyncio
@pytest.mark.skipif(not EXTERNAL_SYSTEM(), reason="Needs network connection.")
async def test_update_ecosystems(self):
await self.osv.update_ecosystems()
ecosystems_txt = make_http_requests(
"text", url=self.ecosystems_url, timeout=300
).strip("\n")
expected_ecosystems = set(ecosystems_txt.split("\n"))
# Because ecosystems.txt does not contain the complete list, this must be
# manually fixed up.
expected_ecosystems.add("DWF")
expected_ecosystems.add("JavaScript")
# Assert that there are no missing ecosystems
> assert all(x in self.osv.ecosystems for x in expected_ecosystems)
E assert False
E + where False = all(<generator object TestSourceOSV.test_update_ecosystems.<locals>.<genexpr> at 0x7fc34fe01b10>)
test/test_source_osv.py:1[84](https://github.com/intel/cve-bin-tool/actions/runs/15675174394/job/44153701064?pr=5143#step:15:85): AssertionError Might this error be due to the problems we are having with the OSV data source? |
I've merged #4929 which should solve the OSV problem so I'm going to try updating this branch |
Signed-off-by: joydeep049 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separation of Concerns for the language parser pipeline for the No-Scan Work.
cc @terriko @anthonyharrison @mastersans