Check for duplicate parameters in shared methods

Author: lwaern-intel

py/dml/traits.py

@@ -324,8 +324,15 @@ def mktrait(site, tname, ancestors, methods, params, sessions, hooks,
         del sessions[name]
 
     bad_methods = set()
-    for (name, (msite, inp, outp, throws, independent, startup, memoized, overridable,
-                body, rbrace_site)) in list(methods.items()):
+    for (name, (msite, inp, outp, throws, independent, startup, memoized,
+                overridable, body, rbrace_site)) in list(methods.items()):
+        argnames = set()
+        for (n, _) in inp:
+            if n in argnames:
+                report(EARGD(msite, n))
+                bad_methods.add(name)
+            if n != '_':
+                argnames.add(n)
         for ancestor in direct_parents:
             coll = ancestor.member_declaration(name)
             if coll:

test/1.4/errors/T_EARGD.dml

@@ -9,3 +9,20 @@ device test;
 /// ERROR EARGD
 method m(int x, int x) {
 }
+
+template t {
+    /// ERROR EARGD
+    shared method m(int x, int x);
+    /// ERROR EARGD
+    shared method n(int x, int x) {}
+}
+
+is t;
+
+method init() {
+    // Ensure that the bad methods do not become part of the device structure
+    /// ERROR EREF
+    this.m(1,1);
+    /// ERROR EREF
+    this.n(1,1);
+}