Skip to content

Commit 77e0f02

Browse files
committed
Merge into one pass
1 parent a255c7b commit 77e0f02

File tree

8 files changed

+7
-68
lines changed

8 files changed

+7
-68
lines changed

include/gc/Transforms/Passes.h

-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ void populateGPUPipeline(mlir::OpPassManager &);
124124
#define GEN_PASS_DECL_CONSTANTTENSORFOLDING
125125
#include "gc/Transforms/Passes.h.inc"
126126

127-
std::unique_ptr<Pass> createConstantSubgraphAnalysisPass();
128127
std::unique_ptr<Pass> createConstantTensorFoldingPass();
129128

130129
#define GEN_PASS_REGISTRATION

include/gc/Transforms/Passes.td

-8
Original file line numberDiff line numberDiff line change
@@ -169,14 +169,6 @@ def MergeNestedForall : Pass<"merge-nested-forall"> {
169169
let dependentDialects = ["scf::SCFDialect"];
170170
}
171171

172-
def ConstantSubgraphAnalysis : Pass<"constant-subgraph-analysis"> {
173-
let summary = "Constant Subgraph Analysis";
174-
let description = [{
175-
This pass implements a constant subgraph analysis.
176-
}];
177-
let constructor = "mlir::gc::createConstantSubgraphAnalysisPass()";
178-
}
179-
180172
def ConstantTensorFolding : Pass<"constant-tensor-folding"> {
181173
let summary = "Constant Tensor Folding Transform";
182174
let description = [{

lib/gc/Transforms/CMakeLists.txt

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ gc_add_mlir_library(GcPasses
1616
IterativeTilingAndFusion.cpp
1717
TilingUsingInterfaceX.cpp
1818
VerifyTargetDescription.cpp
19-
ConstantSubgraphAnalysis.cpp
2019
ConstantTensorFolding.cpp
2120
DecomposeAggregatedOps.cpp
2221
DeepTileContractionOp.cpp

lib/gc/Transforms/ConstantSubgraphAnalysis.cpp

-54
This file was deleted.

lib/gc/Transforms/ConstantTensorFolding.cpp

+5
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#include <iostream>
1414
#include <unordered_set>
1515

16+
#include "gc/Analysis/DataFlow/ConstantSubgraphAnalyser.h"
1617
#include "mlir/Transforms/Passes.h"
1718

1819
#include "mlir/Dialect/Arith/IR/Arith.h"
@@ -766,6 +767,10 @@ void ConstantTensorFolding::runOnOperation() {
766767
MLIRContext *context = topOp->getContext();
767768
auto &topFunc =
768769
topOp->getRegions().front().getBlocks().front().getOperations().front();
770+
771+
dataflow::RunConstantSubgraphAnalyser runAnalyser;
772+
(void)runAnalyser.run(&topFunc);
773+
769774
OpBuilder builder(context);
770775
Region &region = topFunc.getRegions().front();
771776
Block &block = region.getBlocks().front();

lib/gc/Transforms/Pipeline.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ void populateFrontendPasses(mlir::OpPassManager &pm) {
5252
void populateTensorPasses(mlir::OpPassManager &pm) {
5353
// todo: padding propagation pass
5454
// todo: layout propagation pass
55-
// todo: tensor constant propagation pass
56-
pm.addPass(createConstantSubgraphAnalysisPass());
5755
pm.addPass(createConstantTensorFoldingPass());
5856
// linalg.matmul lowering to (scf.loop + linalg.brgemm) pass
5957
pm.addNestedPass<func::FuncOp>(createDeepTileContractionOp());

test/gc/Transforms/test_constant_tensor_folding-0.mlir

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: gc-opt --split-input-file -pass-pipeline="builtin.module(constant-subgraph-analysis,constant-tensor-folding)" %s | FileCheck %s
1+
// RUN: gc-opt --split-input-file -pass-pipeline="builtin.module(constant-tensor-folding)" %s | FileCheck %s
22

33
// COM:A complete example of compile-time and runtime folding.
44

test/gc/Transforms/test_constant_tensor_folding-1.mlir

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: gc-opt --split-input-file -pass-pipeline="builtin.module(constant-subgraph-analysis,constant-tensor-folding)" %s | FileCheck %s
1+
// RUN: gc-opt --split-input-file -pass-pipeline="builtin.module(constant-tensor-folding)" %s | FileCheck %s
22

33
// COM: Test the 'postponeBroadcast' feature of constant tensor folding.
44

0 commit comments

Comments
 (0)