Skip to content

Commit 9c076db

Browse files
committed
Fix static gc-opt build & add comments for components registration
1 parent 09b4029 commit 9c076db

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/gc-opt/CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,21 @@ if(GC_DEV_LINK_LLVM_DYLIB)
2121
)
2222
get_property(dialect_libs GLOBAL PROPERTY GC_DIALECT_LIBS)
2323
get_property(conversion_libs GLOBAL PROPERTY GC_PASS_LIBS)
24+
get_property(extension_libs GLOBAL PROPERTY GC_EXTENSION_LIBS)
2425
else()
2526
set(MLIR_LINK_COMPONENTS
2627
MLIROptLib
28+
MLIRToLLVMIRTranslationRegistration
2729
)
2830
get_property(dialect_libs GLOBAL PROPERTY MLIR_DIALECT_LIBS)
2931
get_property(conversion_libs GLOBAL PROPERTY MLIR_CONVERSION_LIBS)
32+
get_property(extension_libs GLOBAL PROPERTY MLIR_EXTENSION_LIBS)
3033
endif()
3134

3235
set(gc_opt_libs
3336
${dialect_libs}
3437
${conversion_libs}
38+
${extension_libs}
3539
${MLIR_LINK_COMPONENTS}
3640
GCPasses
3741
GCGPUPasses)

src/gc-opt/gc-opt.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ int main(int argc, char *argv[]) {
6161
registry.insert<mlir::linalgx::LinalgxDialect>();
6262
registry.insert<mlir::gen::GENDialect>();
6363
mlir::registerAllDialects(registry);
64+
// covers lowerings for weird dialects like ub
65+
// TODO: avoid `registerALL` to remove this
6466
mlir::registerAllExtensions(registry);
67+
// Adds missing `LLVMTranslationDialectInterface` registration for dialect for
68+
// gpu.module op
6569
mlir::registerAllToLLVMIRTranslations(registry);
6670
mlir::gen::registerGenTargetInterfaceExternalModels(registry);
6771
mlir::registerGENDialectTranslation(registry);

0 commit comments

Comments
 (0)