Skip to content

Commit d90b475

Browse files
Small fixes.
1 parent 787192b commit d90b475

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

sycl/source/detail/queue_impl.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@ event queue_impl::submitMemOpHelper(const std::shared_ptr<queue_impl> &Self,
505505
if (isInOrder()) {
506506
auto &EventToStoreIn = MGraph.expired() ? MDefaultGraphDeps.LastEventPtr
507507
: MExtGraphDeps.LastEventPtr;
508-
EventToStoreIn = EventImpl;
508+
EventToStoreIn = std::move(EventImpl);
509509
}
510510
// Track only if we won't be able to handle it with urQueueFinish.
511511
if (MEmulateOOO)

sycl/unittests/scheduler/EnqueueWithDependsOnDeps.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,7 @@ TEST_F(DependsOnTests, ShortcutFunctionWithWaitList) {
323323
&redefinedextUSMEnqueueMemcpy);
324324
sycl::queue Queue = detail::createSyclObjFromImpl<queue>(QueueDevImpl);
325325

326+
// Mock up an incomplete host task
326327
auto HostTaskEvent =
327328
Queue.submit([&](sycl::handler &cgh) { cgh.host_task([=]() {}); });
328329
std::shared_ptr<detail::event_impl> HostTaskEventImpl =
@@ -332,8 +333,6 @@ TEST_F(DependsOnTests, ShortcutFunctionWithWaitList) {
332333
ASSERT_NE(Cmd, nullptr);
333334
Cmd->MIsBlockable = true;
334335
Cmd->MEnqueueStatus = detail::EnqueueResultT::SyclEnqueueBlocked;
335-
// for the test functionality, depenent task HostTaskEvent must be treated as
336-
// incompleted
337336
HostTaskEventImpl->setStateIncomplete();
338337

339338
auto SingleTaskEvent = Queue.submit([&](sycl::handler &cgh) {

0 commit comments

Comments
 (0)