[WASM] There is a build error with Emscripten (newest version 1.38.46) tool on WASM

[cuiyanx]

There is a build error with Emscripten (newest version 1.38.46) tool on WASM. The tensorflow version is 1.13.
Error info:

[cuiyanx]

I try to build nn_ops.js with binding.cpp and Emscripten (newest version 1.38.46) tool and Tensorflow (branch r1.15), and get 8 errors.

error info:
1.

2.

3.

4.

5.

6.

7.

8.

[huningxin]

@akineeic , could you please investigate this issue? thanks.

[Wenzhao-Xiang]

There is a build error with Emscripten (newest version 1.38.46) tool on WASM. The tensorflow version is 1.13.
Error info:

To my understanding, it's the issue of Runtimeshape binding, you can change it to

class_<RuntimeShape>("RuntimeShape")
    .constructor<int>()
    .function("DimensionsCount", &RuntimeShape::DimensionsCount)
    .function("Dims", &RuntimeShape::Dims)
    .function("SetDim", &RuntimeShape::SetDim)
    ;

[huningxin]

Thanks @Wenzhao-Xiang . @akineeic , could you please follow Wenzhao's suggestion and create a PR?

[Wenzhao-Xiang]

I try to build nn_ops.js with binding.cpp and Emscripten (newest version 1.38.46) tool and Tensorflow (branch r1.15), and get 8 errors.

In the r1.15 release, tflite changed some API definitions, so we need to modify the binding.cpp to match them first. The biggest difference is that it uses CpuBackendContext to integrate Eigen, Gemmlowp and its own experimental library Ruby, which makes the API more concise to use. I did some work to update the tensorflow version before, but it seems that there are some issue with the toolchain when compiling CpuBackendContext. I haven't investegated this issue yet.
Hope this information can help you if you want to update the tf version.

[akineeic]

Thanks @Wenzhao-Xiang . @akineeic , could you please follow Wenzhao's suggestion and create a PR?

Thanks @Wenzhao-Xiang , I have reproduced the error and solved it followed wenzhao's suggestion. It seems caused by the version of Emscripten. I'll make a PR later.

[akineeic]

This issue has fixed in #1021.
Close the issue.

[huningxin]

@akineeic , the process is that we close the issue after PR merged. And if you put fix key word in your PR, the issue will be automatically closed after PR merged. Please check out https://help.github.com/en/articles/closing-issues-using-keywords

[akineeic]

@akineeic , the process is that we close the issue after PR merged. And if you put fix key word in your PR, the issue will be automatically closed after PR merged. Please check out https://help.github.com/en/articles/closing-issues-using-keywords

Thanks @huningxin, I have modified the pull request description.

[akineeic]

It seems that the version 1.38.41 or later of emscripten does't support our code of constructor's overload. To overload the constructor of RuntimeShape correctly, I have created an issue in emscripten repo. Waiting for their advanced infomation.

[huningxin]

Thanks @akineeic . Let's see upstream's inputs. As your PR #1021 works for both 1.38.40 and 1.38.41. It's kind of working.