Merge pull request #107 from intercom/jo/handle-emprty-email-updates

dont try to update empty emails

Author: josler

lib/ext/sliceable_hash.rb

@@ -7,6 +7,10 @@ def initialize(hash)
   # Return a hash that includes only the given keys.
   def slice(*keys)
     keys.map! { |key| @hash.convert_key(key) } if @hash.respond_to?(:convert_key, true)
-    keys.each_with_object(@hash.class.new) { |k, hash| hash[k] = @hash[k] if @hash.has_key?(k) }
+    keys.each_with_object(@hash.class.new) { |k, hash| hash[k] = @hash[k] if @hash.has_key?(k) && if_string_not_empty(@hash[k]) }
+  end
+  
+  def if_string_not_empty(val)
+    val.kind_of?(String) ? !val.empty? : true
   end
 end

spec/unit/intercom/user_spec.rb

@@ -165,6 +165,12 @@
     Intercom.expects(:post).with("/users", {'custom_attributes' => {}, "email" => "[email protected]", "user_id" => "i-1224242", "companies" => [{"company_id" => 6, "name" => "Intercom"}]}).returns({"email" => "[email protected]", "user_id" => "i-1224242"})
     user.save
   end
+  
+  it 'can save a user with a nil email' do
+    user = Intercom::User.new("email" => nil, :user_id => "i-1224242", :companies => [{'company_id' => 6, 'name' => "Intercom"}])
+    Intercom.expects(:post).with("/users", {'custom_attributes' => {}, "email" => nil, "user_id" => "i-1224242", "companies" => [{"company_id" => 6, "name" => "Intercom"}]}).returns({"email" => nil, "user_id" => "i-1224242"})
+    user.save
+  end
 
   it "deletes a user" do
     user = Intercom::User.new("id" => "1")