Allowing company users to be listed by company_id#428
Merged
Conversation
|
Addresses #392 |
colinfkennedy
requested changes
Oct 1, 2018
colinfkennedy
approved these changes
Oct 1, 2018
colinfkennedy
left a comment
colinfkennedy
left a comment
There was a problem hiding this comment.
My bad, didn't know the version update was automatic
Member
|
Cool, this looks really tidy as well, nice work @jonnyom @colinfkennedy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
We currently can't list users from a company by external
company_id.How?
This adds two methods to the
Companyclass which specifies whether to look users up by Intercom Company ID, or by externalcompany_id.We've also deleted the unnecessary ExtendedApiOPerations::User module.