Skip to content

fix top menu feedback on mobile #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2025
Merged

fix top menu feedback on mobile #157

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
50178ab
fix top menu feedback
mustafa-sayyed Oct 12, 2025
c0fb2ec
fix: unify active menu item styles for better consistency
mustafa-sayyed Oct 20, 2025
273c336
fix: remove identical styling
mustafa-sayyed Oct 22, 2025
a147f72
run formatting
Anca2022 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/pages/FoundationHeader.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,11 +317,15 @@ import ExternalIcon from "../../../public/img/icon-external.svg";
}

.menu-item--level-1 > .is-active {
Copy link
Contributor

@Anca2022 Anca2022 Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS property values for the mobile media query that match the ones on the main interledger.org website are the following (and are identical to those for desktop):
text-decoration-thickness: 2px;
text-underline-offset: 8px;
To avoid repetition, consider moving these shared rules outside the media query.

Copy link
Contributor Author

@mustafa-sayyed mustafa-sayyed Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, Thanks @Anca2022, have made the changes

Copy link
Contributor

@Anca2022 Anca2022 Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on interledger.org/developers (styled at 5px underline-offset):
image

This is on interledger.org/open-standards (styled at 8px underline-offset) - this is what we want to replicate:
image

As I mentioned previously, on mobile the values are the same as on desktop:

text-decoration-thickness: 2px;
text-underline-offset: 8px;

border-inline-start: 2px solid var(--color-header-accent);
text-decoration: underline;
text-decoration-thickness: 1.5px;
text-underline-offset: 5px;
}

.menu-item--level-2 > .is-active {
text-decoration: underline;
text-decoration-thickness: 1.5px;
text-underline-offset: 5px;
}

.switch-link:hover {
Expand Down