Skip to content

Incremental Load pull handler should recompile sub-classes. #882

@cambot

Description

@cambot

Currently in SourceControl.Git.PullEventHandler.IncrementalLoad, it uses the ck compile flags on the subset of files being loaded through the git operation (be it pull, merge, checkout branch, etc..):

set sc = $$$ADDSC(sc,$system.OBJ.CompileList(.compilelist, "ck"))

However, if a class in an inheritance hierarchy is modified, then sub-classes are not recompiled if there is a change to a parent/base class. This can potentially introduce subtle bugs that are difficult to spot because the high level code "looks right", but the underlying compiled code is out of date.

At a minimum, can the compile flags be updated to ckb to include compiling sub-classes (Source). Members on our team also include u-Skip up to date classes, but I'm not sure if that is necessary in this case.

Alternatively, I think a better long term solution is to allow projects to define their list of compile flags and save them in embedded-git-config.json.


Module Version: 2.13.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    customerBased on customer feedback (as opposed to something identified by developers)

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions