Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: community curator can't easily see in a request if there are failing checks #1133

Closed
8 tasks done
Tracked by #1130
Assignees

Comments

@slint
Copy link
Member

slint commented Mar 20, 2025

When a community curator receives a new inclusion/review request, just by looking at the request page (or the record preview) there's no clear indication of any failing checks.

We should explore adding the "summary" box from the original mockups above the comment textbox.

  • Based on existing work in Check runs inveniosoftware/invenio-checks#26
  • In app-rdm, change request jinja template to show a check tab if CHECKS_ENABLED=true and if there is any check for this request
  • In app-rdm, change request jinja template to show a status icon (errors, warning, success) in the check tab title based on the latest check overall status
  • In invenio-checks, create a service to retrieve the latest check for a request (move logic from app-rdm to invenio-checks)
  • Show content inside the checks tab (in which module?)
    • Since high interactivity not needed, if possible, implement in jinja like the records preview tab
    • Otherwise, change request jinja template to inject something like data-checks next to data-record inside <div id="request-detail" with a the JSON details needed to display https://doi.org/10.5281/zenodo.10901185 (bottom of page 10) and implement the checks tab content React
  • Move the template to invenio-checks
  • UI looking lis the mockup

Screenshot of the feature

@slint slint changed the title Community curator can't easily see in a request if there are failing checks just by looking at the request page (or the record preview) checks: community curator can't easily see in a request if there are failing checks Mar 20, 2025
@slint slint mentioned this issue Mar 20, 2025
18 tasks
@ptamarit ptamarit moved this to In progress in Sprint Q1/2025 Mar 21, 2025
@github-project-automation github-project-automation bot moved this from In progress to To release 🤖 in Sprint Q1/2025 Mar 21, 2025
@carlinmack carlinmack reopened this Mar 21, 2025
@ptamarit ptamarit moved this from To release 🤖 to In progress in Sprint Q1/2025 Mar 24, 2025
@github-project-automation github-project-automation bot moved this from In progress to To release 🤖 in Sprint Q1/2025 Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants