WIP: fix(vcs): remove VCS_INTEGRATION_ENABLED

* We are now distributing this module as an optional dependency rather
than pre-bundled with InvenioRDM. So the new way of
activating/deactivating the module is installing/uninstalling it.

* Also, the default value for `VCS_PROVIDERS` is an empty list, so
nothing would be rendered in the UI menu anyway.

Author: palkerecsenyi

invenio_vcs/ext.py

@@ -86,15 +86,13 @@ def init_config(self, app):
 
 def finalize_app_ui(app):
     """Finalize app."""
-    if app.config.get("VCS_INTEGRATION_ENABLED", False):
-        init_menu(app)
-        init_webhooks(app)
+    init_menu(app)
+    init_webhooks(app)
 
 
 def finalize_app_api(app):
     """Finalize app."""
-    if app.config.get("VCS_INTEGRATION_ENABLED", False):
-        init_webhooks(app)
+    init_webhooks(app)
 
 
 def init_menu(app):

invenio_vcs/views/vcs.py

@@ -65,9 +65,8 @@ def create_ui_blueprint(app):
         template_folder="../templates",
         url_prefix="/account/settings/vcs/<provider>",
     )
-    if app.config.get("VCS_INTEGRATION_ENABLED", False):
-        with app.app_context():  # Todo: Temporary fix, it should be removed when inveniosoftware/invenio-theme#355 is merged
-            register_ui_routes(blueprint)
+    with app.app_context():  # Todo: Temporary fix, it should be removed when inveniosoftware/invenio-theme#355 is merged
+        register_ui_routes(blueprint)
     return blueprint
 
 
@@ -76,8 +75,7 @@ def create_api_blueprint(app):
     blueprint_api = Blueprint(
         "invenio_vcs_api", __name__, url_prefix="/user/vcs/<provider>"
     )
-    if app.config.get("VCS_INTEGRATION_ENABLED", False):
-        register_api_routes(blueprint_api)
+    register_api_routes(blueprint_api)
     return blueprint_api