Reviews per record version

[palkerecsenyi]

Tracking implementation in inveniosoftware/invenio-app-rdm#3403

---

We would like to implement support for requiring a community review for each version of a record. Currently, only the first version is subject to a review (via a Community Submission Request), and all future versions are published immediately without review.

For now, we'd like to keep it simple, so this would be our proposed implementation:

• Only applies to the default community of a record (usually the one it was originally submitted to during publication).

  • For other communities, only the version for which the Community Inclusion Request was created will be subject to a review. Future versions will show up as part of those communities without further review.

• Will be configurable on the instance level. It will be behind a feature flag so disabled by default, meaning the current behaviour does not change. If enabled, by default, all new versions of records submitted to their default community will be automatically subject to a review. You will be able to provide a function in your instance's invenio.cfg, e.g. def requires_review(identity, record, community) -> bool to override this behaviour. E.g. you could disable/enable it for specific communities.

• Add a link to the request for each version on the record detail page in the version list, shown to users authorised to view them. Perhaps as an additional icon or something similar. Here is the current design for reference:
  

  • Users can view requests for versions other than the ones shown by navigating to their desired record and clicking the corresponding button.

• Implement the data model changes in a way that minimises the migration complexity as much as possible. We will probably have to:

  • Modify the rdm_parents_community table to allow storing a request_id per record version. Right now it has one row per parent record / community combo, so this might be tricky.
  • Modify the review field of the RDMParent record, perhaps move this to RDMRecord.

---

Please feel free to respond with any comments, questions or suggestions :)
Thank you!

[egabancho]

Will you also consider metadata-only changes? i.e, the user changes the description, but no new version is created.

[zzacharo]

This is not on the current scope. We have added a mechanism for instance owners to define a "RequireReviewPolicy" class but this is checked only on new_version calls. I would say to implement your use case the most tricky part is to implement the frontend state but invenio-curations has already some of this functionality.

You can see the current implementation here.