Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Stock Expiry when Receiving Line Item in PO #6176

Open
2 tasks done
jacobfelknor opened this issue Jan 8, 2024 · 12 comments
Open
2 tasks done

[FR] Stock Expiry when Receiving Line Item in PO #6176

jacobfelknor opened this issue Jan 8, 2024 · 12 comments
Assignees
Labels
enhancement This is an suggested enhancement or new feature Fund This issue can be specifically funded for development inactive Indicates lack of activity order Related to purchase orders / sales orders User Interface Related to the frontend / User Interface
Milestone

Comments

@jacobfelknor
Copy link
Contributor

jacobfelknor commented Jan 8, 2024

Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find a similar feature request

Problem statement

When receiving line items - thus generating stock - from the PO view, you are unable to set an expiry on the stock item being generated. Instead, we must then go to the received stock item created after the receive event and edit it to add the expiry. This isn't that annoying, but there are options to add a batch code or location from this view.

Suggested solution

Add another option for expire date for a stock item being received from a PO, similar to how you can add a batch code. In would also be helpful to add any stock item notes from this view

Describe alternatives you've considered

As mentioned, we are just going to the detail view after the line item receive and adding the expire date after the fact. This is fine, but an extra step that could be forgotten or done incorrectly (accidently navigate to wrong stock item)

Examples of other systems

No response

Do you want to develop this?

  • I want to develop this.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@jacobfelknor jacobfelknor added enhancement This is an suggested enhancement or new feature triage:not-checked Item was not checked by the core team labels Jan 8, 2024
@jacobfelknor
Copy link
Contributor Author

If you have other suggestions for a better way of accomplishing this, let me know. I am still learning the system

@SchrodingersGat SchrodingersGat added user interface order Related to purchase orders / sales orders and removed triage:not-checked Item was not checked by the core team labels Jan 10, 2024
@SchrodingersGat
Copy link
Member

I can see the usefulness of this. Would you be willing to look into contributing this feature?

@jacobfelknor
Copy link
Contributor Author

jacobfelknor commented Jan 12, 2024

I could definitely take a look. It may be some time before I can get to it though, which is fine. I'm not particularly in a rush. You can assign me the issue and I'll see where I get

@jacobfelknor
Copy link
Contributor Author

For this to be considered complete, we probably also need to update inventree-python's PurchaseOrderLineItem.receive function

https://github.com/inventree/inventree-python/blob/master/inventree/purchase_order.py#L207-L220

@SchrodingersGat
Copy link
Member

Ok, assigned, feel free to ping me when you get a chance.

Note that we are currently pushing to refactor the entire front-end into react. So, any front-end / UI / UX features should be implemented only in the new React interface

@SchrodingersGat SchrodingersGat added the User Interface Related to the frontend / User Interface label Jan 13, 2024
Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label Mar 14, 2024
@matmair matmair removed the inactive Indicates lack of activity label Mar 14, 2024
Copy link
Contributor

This issue seems stale. Please react to show this is still important.

@github-actions github-actions bot added the inactive Indicates lack of activity label May 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
@jsherman256
Copy link

I would very much like this feature

@SchrodingersGat SchrodingersGat added the Fund This issue can be specifically funded for development label Jan 6, 2025
@SchrodingersGat SchrodingersGat added this to the horizon milestone Jan 6, 2025
@SchrodingersGat
Copy link
Member

SchrodingersGat commented Jan 6, 2025

@jacobfelknor @jsherman256 would either of you be willing to implement this feature, or alternatively provide funding towards its development?

The new user interface is now sufficiently advanced that this could be added with reasonable ease

@jacobfelknor
Copy link
Contributor Author

I will revisit

@jacobfelknor
Copy link
Contributor Author

jacobfelknor commented Jan 9, 2025

I've just opened a PR #8867

I still agree with my earlier statement:

For this to be considered complete, we probably also need to update inventree-python's PurchaseOrderLineItem.receive function

https://github.com/inventree/inventree-python/blob/master/inventree/purchase_order.py#L207-L220

I can also look at that

@jacobfelknor
Copy link
Contributor Author

jacobfelknor commented Jan 9, 2025

I've opened inventree/inventree-python#254 adding this new arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature Fund This issue can be specifically funded for development inactive Indicates lack of activity order Related to purchase orders / sales orders User Interface Related to the frontend / User Interface
Projects
None yet
Development

No branches or pull requests

4 participants