Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result count only goes as high as number of items on first screen #9135

Closed
2 of 6 tasks
motusRP opened this issue Feb 21, 2025 · 5 comments
Closed
2 of 6 tasks
Labels
bug Identifies a bug which needs to be addressed question This is a question
Milestone

Comments

@motusRP
Copy link

motusRP commented Feb 21, 2025

Please verify that this bug has NOT been raised before.

  • I checked and didn't find a similar issue

Describe the bug*

I have over 100 Digikey parts in my Inventree setup. If I do a search for "digikey" that search finds them all, and gives me a screen where I can scroll through them 25 at a time. In the navigation bar at the left it tells me how many Parts, Supplier Parts, etc. that also show "Digikey" in the results. For Parts, it has a little highlight ball that says "25" in it, when clearly there are more than 25 Parts with Digikey:

Image

Steps to Reproduce

  1. Go to the main search box at the top of the page
  2. Search for a term that you know you have more than 25 of (or your default number of items to show in a search, if that's changeable)
  3. Note the discrepancy between the number of search results and the number highlighted in the menu on the left side of the screen.

Note that if you have, say, 112 items in the results, and you move to the 5th page of results (assuming 25 items per page), the highlight number in the list on the left will change from 25 to 12.

Note2: I can't reproduce this on the Demo site, because search results only stay in the search window popup. This seems like a loss of functionality as well... There doesn't seem to be a way to get a search result for all items that match the search terms?

Expected behaviour

Expect the count to be the total of all search results in that category, not just those shown in the abbreviated search results list on the current screen.

Deployment Method

  • Docker
  • Package
  • Bare metal
  • Other - added info in Steps to Reproduce

Version Information

Version Information:

InvenTree-Version: 0.17.1
Django Version: 4.2.17
Commit Hash: eed6223
Commit Date: 2024-12-26

Database: postgresql
Debug-Mode: False
Deployed using Docker: True
Platform: Linux-5.15.0-131-generic-x86_64-with
Installer: DOC

Active plugins: [{'name': 'InvenTreeBarcode', 'slug': 'inventreebarcode', 'version': '2.1.0'}, {'name': 'InvenTreeCoreNotificationsPlugin', 'slug': 'inventreecorenotificationsplugin', 'version': '1.0.0'}, {'name': 'InvenTreeCurrencyExchange', 'slug': 'inventreecurrencyexchange', 'version': '1.0.0'}, {'name': 'InvenTreeLabel', 'slug': 'inventreelabel', 'version': '1.1.0'}, {'name': 'InvenTreeLabelMachine', 'slug': 'inventreelabelmachine', 'version': '1.0.0'}, {'name': 'InvenTreeLabelSheet', 'slug': 'inventreelabelsheet', 'version': '1.0.0'}, {'name': 'DigiKeyPlugin', 'slug': 'digikeyplugin', 'version': '1.0.0'}, {'name': 'LCSCPlugin', 'slug': 'lcscplugin', 'version': '1.0.0'}, {'name': 'MouserPlugin', 'slug': 'mouserplugin', 'version': '1.0.0'}, {'name': 'TMEPlugin', 'slug': 'tmeplugin', 'version': '1.0.0'}]

Please verify if you can reproduce this bug on the demo site.

  • I can reproduce this bug on the demo site.

Relevant log output

@motusRP motusRP added bug Identifies a bug which needs to be addressed question This is a question triage:not-checked Item was not checked by the core team labels Feb 21, 2025
@SchrodingersGat
Copy link
Member

In the new user interface this has been addressed:

Image

As the old UI is deprecated and no longer present in the master branch, back porting a fix for this would be a low priority. If you want to submit a patch for this I'd accept it :)

@motusRP
Copy link
Author

motusRP commented Feb 21, 2025

In the new user interface this has been addressed:

I looked at the new UI in the demo site, but the new UI doesn't let you see all of the results, just the first 10 or so that show up. In your example, how could I get the list of all 165 Supplier Parts? The old UI was much better at this IMO.

@SchrodingersGat
Copy link
Member

@motusRP great point about the ability to see all the results for a particular group. This has been overlooked in the new UI.

I have created a new PR to fix this - #9137

@matmair matmair added this to the 1.0.0 milestone Feb 22, 2025
@matmair matmair removed the triage:not-checked Item was not checked by the core team label Feb 22, 2025
@matmair
Copy link
Member

matmair commented Feb 22, 2025

Was this addressed by #9137?

@SchrodingersGat
Copy link
Member

Yes, I think it is now sufficiently addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed question This is a question
Projects
None yet
Development

No branches or pull requests

3 participants