You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using inversify-vanillajs-helpers with webpack im seeing its being packed together with inversify adding unnecessary size:
Expected Behavior
After installing inversify-vanillajs-helpers I don't get inversify in its dependencies that is node_modules/inversify-vanillajs-helpers/node_modules/inversify should not exists.
Current Behavior
When installing inversify-vanillajs-helpers it has duplicate of inversify in node_modules/inversify-vanillajs-helpers/node_modules/inversify.
npm run demo:analyze - this will show module dependencies like on that screen above
Context
Unnecessary increases size of build. Also it requires inversify-vanillajs-helpers library update to sync with inversify currently its locked at 4.11.0.
When using

inversify-vanillajs-helpers
with webpack im seeing its being packed together withinversify
adding unnecessary size:Expected Behavior
After installing
inversify-vanillajs-helpers
I don't getinversify
in its dependencies that isnode_modules/inversify-vanillajs-helpers/node_modules/inversify
should not exists.Current Behavior
When installing
inversify-vanillajs-helpers
it has duplicate ofinversify
innode_modules/inversify-vanillajs-helpers/node_modules/inversify
.Possible Solution
package.json in
inversify-vanillajs-helpers
Although I am not sure if its enough for gulp build (for example in rollup you need to set it additionally as external library).
Alternative would be to use for example https://github.com/alexjoverm/typescript-library-starter and set externals in rollup to 'inversify'.
But this one would require rewriting library to use rollup.
Steps to Reproduce (for bugs)
I have noticed it when trying out it in https://github.com/Xesenix/webpack-3-scaffold/tree/DI
Context
Unnecessary increases size of build. Also it requires
inversify-vanillajs-helpers
library update to sync withinversify
currently its locked at4.11.0
.Your Environment
node v9.6.1
npm 5.7.1
https://github.com/Xesenix/webpack-3-scaffold/tree/DI
The text was updated successfully, but these errors were encountered: