-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request: Let flutterfire_cli be installable as dev dependency #242
Comments
Similar as #223 |
Technically, you can add it as a dev dependency and run dart run flutterfire_cli:flutterfire_dev. However, the cli project uses an old version of the http package, which has dependency conflicts with most some of my packages. |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
Not stale |
Hey @cedvdb - I'm in favour of making this a dev dependency, but not sure if that would work when we call flutterfire from Xcode build phaes. e.g. https://github.com/invertase/flutterfire_cli/blob/main/packages/flutterfire_cli/lib/src/firebase/firebase_apple_writes.dart#L376 Happy to take a look at a PR if you were interested in trying to get this over the line |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
@russellwheatley the ios script should be updated to have |
@cedvdb - Of the top of my head, I think it is the two Apple scripts that we add to build phases that need to be updated: https://github.com/invertase/flutterfire_cli/blob/main/packages/flutterfire_cli/lib/src/firebase/firebase_apple_writes.dart#L11-L14 |
I'm curious if any of these are used in the cli. Maybe extracting these in
a separate package that is installed as dev dependency could be a good idea
and it could benefit other stuff.
…On Fri, Feb 14, 2025, 5:18 a.m. Russell Wheatley ***@***.***> wrote:
@cedvdb <https://github.com/cedvdb> - Of the top of my head, I think it
is the two Apple scripts that we add to build phases that need to be
updated:
https://github.com/invertase/flutterfire_cli/blob/main/packages/flutterfire_cli/lib/src/firebase/firebase_apple_writes.dart#L11-L14
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJNAJ6G3LLJDJFB4XTBDEL2PW7HZAVCNFSM6AAAAABPC7P7W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJYHA4TONJVGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: russellwheatley]*russellwheatley* left a comment
(invertase/flutterfire_cli#242)
<#242 (comment)>
@cedvdb <https://github.com/cedvdb> - Of the top of my head, I think it
is the two Apple scripts that we add to build phases that need to be
updated:
https://github.com/invertase/flutterfire_cli/blob/main/packages/flutterfire_cli/lib/src/firebase/firebase_apple_writes.dart#L11-L14
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJNAJ6G3LLJDJFB4XTBDEL2PW7HZAVCNFSM6AAAAABPC7P7W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJYHA4TONJVGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Why extracting those ? The commands in the ios script needs to be rewritten to use the dev dependency with |
Not in favour of extracting those script separate package. |
Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions. |
Is there an existing feature request for this?
Command
dart run flutterfire || dart run flutterfire_cli
Description
currently the filename in /bin does not match the package name. When installing flutterfire_cli as a dev dependency and then trying to run it here is the output:
Reasoning
I want to lock the version.
Additional context and comments
No response
The text was updated successfully, but these errors were encountered: