Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: run dart format on firebase_options.dart #290

Open
1 task done
erf opened this issue Apr 23, 2024 · 1 comment
Open
1 task done

[bug]: run dart format on firebase_options.dart #290

erf opened this issue Apr 23, 2024 · 1 comment
Labels
enhancement New feature or request keep open

Comments

@erf
Copy link

erf commented Apr 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

CLI Version

1.0.0

Firebase Tools version

13.7.2

Flutter Doctor Output

[✓] Flutter (Channel stable, 3.19.6, on macOS 14.4.1 23E224 darwin-arm64,
    locale en-NO)
    • Flutter version 3.19.6 on channel stable at /Users/erlend/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (6 days ago), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version
    34.0.0)
    • Android SDK at /Users/erlend/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/erlend/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/erlend/Library/Android/sdk
    • Java binary at: /Users/erlend/Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.9+0-17.0.9b1087.7-11185874)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15E204a
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.2)
    • Android Studio at /Users/erlend/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.9+0-17.0.9b1087.7-11185874)

[✓] VS Code (version 1.88.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.87.20240402

[✓] Connected device (3 available)
    • Erlend sin iPhone (mobile) • 00008130-001E61A92403401C • ios            • iOS 17.4.1 21E236
    • macOS (desktop)            • macos                     • darwin-arm64   • macOS 14.4.1 23E224 darwin-arm64
    • Chrome (web)               • chrome                    • web-javascript • Google Chrome 124.0.6367.62

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Description

I noticed firebase_options.dart is not formatted correctly according to dart format (i got a built error on the server).

Diff after running dart format:

diff --git a/lib/firebase_options.dart b/lib/firebase_options.dart
index 22bbfef6..9c85f9e2 100644
--- a/lib/firebase_options.dart
+++ b/lib/firebase_options.dart
-
-}
\ No newline at end of file
+}

Steps to reproduce

run flutterfire configure

Expected behavior

I'd excpect it to be formatted according to dart format

Screenshots

No response

Additional context and comments

No response

@erf erf added bug Something isn't working triage labels Apr 23, 2024
@russellwheatley russellwheatley added enhancement New feature or request and removed triage bug Something isn't working labels May 17, 2024
Copy link

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 30, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep open
Projects
None yet
Development

No branches or pull requests

2 participants