Merge pull request #34 from invokable/devin/1733103292-install-laravel-pint

Install Laravel Pint and Setup Code Style Automation

Author: kawax

.github/workflows/lint.yml

@@ -0,0 +1,42 @@
+name: linter
+
+on:
+  push:
+    branches:
+      - develop
+      - main
+  pull_request:
+    branches:
+      - develop
+      - main
+
+permissions:
+  contents: write
+
+jobs:
+  quality:
+    runs-on: ubuntu-latest
+    environment: Testing
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.4'
+
+      - name: Install Dependencies
+        run: |
+          composer install -q --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist
+
+      - name: Run Lint
+        run: vendor/bin/pint --test
+
+      # - name: Commit Changes
+      #   uses: stefanzweifel/git-auto-commit-action@v5
+      #   with:
+      #     commit_message: fix code style
+      #     commit_options: '--no-verify'
+      #     file_pattern: |
+      #       **/*
+      #       !.github/workflows/*

composer.json

@@ -14,7 +14,8 @@
   },
   "require-dev": {
     "orchestra/testbench": "^10.0",
-    "pulkitjalan/google-apiclient": "^6.2"
+    "pulkitjalan/google-apiclient": "^6.2",
+    "laravel/pint": "^1.22"
   },
   "autoload": {
     "psr-4": {

lib/google/Exceptions/UnknownServiceException.php

@@ -2,6 +2,4 @@
 
 namespace Revolution\Google\Client\Exceptions;
 
-class UnknownServiceException extends \Exception
-{
-}
+class UnknownServiceException extends \Exception {}

lib/google/GoogleApiClient.php

@@ -93,7 +93,6 @@ protected function auth(string $userEmail = ''): void
     /**
      * Determine and use credentials if user has set them.
      *
-     * @param  string  $userEmail
      * @return bool used or not
      */
     protected function useAssertCredentials(string $userEmail = ''): bool
@@ -116,8 +115,6 @@ protected function useAssertCredentials(string $userEmail = ''): bool
     /**
      * Magic call method.
      *
-     * @param  string  $method
-     * @param  array  $parameters
      * @return mixed
      *
      * @throws BadMethodCallException

pint.json

@@ -0,0 +1,6 @@
+{
+    "preset": "laravel",
+    "rules": {
+        "no_unused_imports": false
+    }
+}

src/Concerns/SheetsValues.php

@@ -19,6 +19,7 @@ trait SheetsValues
     protected ?string $majorDimension = null;
 
     protected ?string $valueRenderOption = null;
+
     protected ?string $dateTimeRenderOption = null;
 
     public function all(): array
@@ -45,10 +46,10 @@ public function update(array $value, string $valueInputOption = 'RAW'): BatchUpd
     {
         $range = $this->ranges();
 
-        $batch = new BatchUpdateValuesRequest();
+        $batch = new BatchUpdateValuesRequest;
         $batch->setValueInputOption($valueInputOption);
 
-        $valueRange = new ValueRange();
+        $valueRange = new ValueRange;
         $valueRange->setValues($value);
         $valueRange->setRange($range);
 
@@ -61,7 +62,7 @@ public function clear(): ?ClearValuesResponse
     {
         $range = $this->ranges();
 
-        $clear = new ClearValuesRequest();
+        $clear = new ClearValuesRequest;
 
         return $this->serviceValues()->clear($this->getSpreadsheetId(), $range, $clear);
     }
@@ -71,7 +72,7 @@ public function append(array $values, string $valueInputOption = 'RAW', string $
         $range = $this->ranges();
         $orderedValues = $this->orderAppendables($values);
 
-        $valueRange = new ValueRange();
+        $valueRange = new ValueRange;
         $valueRange->setValues($orderedValues);
         $valueRange->setRange($range);
 

src/Facades/Sheets.php

@@ -48,8 +48,6 @@ class Sheets extends Facade
 {
     /**
      * Get the registered name of the component.
-     *
-     * @return string
      */
     protected static function getFacadeAccessor(): string
     {

src/SheetsClient.php

@@ -15,10 +15,10 @@
 
 class SheetsClient implements Factory
 {
-    use Concerns\SheetsValues;
+    use Concerns\SheetsCollection;
     use Concerns\SheetsDrive;
     use Concerns\SheetsProperties;
-    use Concerns\SheetsCollection;
+    use Concerns\SheetsValues;
     use Conditionable;
     use Macroable {
         __call as macroCall;

tests/ClientTest.php

@@ -11,21 +11,21 @@
 
 class ClientTest extends TestCase
 {
-    public function tearDown(): void
+    protected function tearDown(): void
     {
         m::close();
 
         parent::tearDown();
     }
 
-    public function testClientGetter()
+    public function test_client_getter()
     {
         $client = m::mock(GoogleApiClient::class, [[]])->makePartial();
 
         $this->assertInstanceOf('Google\Client', $client->getClient());
     }
 
-    public function testClientGetterWithAdditionalConfig()
+    public function test_client_getter_with_additional_config()
     {
         $client = m::mock(GoogleApiClient::class, [[
             'config' => [
@@ -36,14 +36,14 @@ public function testClientGetterWithAdditionalConfig()
         $this->assertEquals('test', $client->getClient()->getConfig('subject'));
     }
 
-    public function testServiceMake()
+    public function test_service_make()
     {
         $client = m::mock(GoogleApiClient::class, [[]])->makePartial();
 
         $this->assertInstanceOf('Google\Service\Storage', $client->make('storage'));
     }
 
-    public function testServiceMakeException()
+    public function test_service_make_exception()
     {
         $client = m::mock(GoogleApiClient::class, [[]])->makePartial();
 
@@ -52,7 +52,7 @@ public function testServiceMakeException()
         $client->make('storag');
     }
 
-    public function testMagicMethodException()
+    public function test_magic_method_exception()
     {
         $client = new GoogleApiClient([]);
 
@@ -61,14 +61,14 @@ public function testMagicMethodException()
         $client->getAuthTest();
     }
 
-    public function testNoCredentials()
+    public function test_no_credentials()
     {
         $client = new GoogleApiClient([]);
 
         $this->assertFalse($client->isUsingApplicationDefaultCredentials());
     }
 
-    public function testDefaultCredentials()
+    public function test_default_credentials()
     {
         $client = new GoogleApiClient([
             'service' => [

tests/SheetsCollectionTest.php

@@ -6,7 +6,7 @@
 
 class SheetsCollectionTest extends TestCase
 {
-    public function testCollection()
+    public function test_collection()
     {
         $header = ['id', 'name', 'mail'];
         $rows = [
@@ -19,7 +19,7 @@ public function testCollection()
         $this->assertEquals('name1', $collection->first()['name']);
     }
 
-    public function testCollection2()
+    public function test_collection2()
     {
         $header = ['id', 'name', 'mail'];
         $rows = [
@@ -32,7 +32,7 @@ public function testCollection2()
         $this->assertNotNull($collection->last()['mail']);
     }
 
-    public function testCollection3()
+    public function test_collection3()
     {
         $rows = collect([
             ['id', 'name', 'mail'],

tests/SheetsDriveTest.php

@@ -21,7 +21,7 @@ class SheetsDriveTest extends TestCase
      */
     protected $files;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
 
@@ -32,7 +32,7 @@ public function setUp(): void
         Sheets::setDriveService($this->service);
     }
 
-    public function testList()
+    public function test_list()
     {
         $file = new DriveFile([
             'id' => 'id',
@@ -50,7 +50,7 @@ public function testList()
         $this->assertSame(['id' => 'name'], $list);
     }
 
-    public function testNull()
+    public function test_null()
     {
         Google::shouldReceive('make')->andReturn($this->service);
 

tests/SheetsMacroTest.php

@@ -6,7 +6,7 @@
 
 class SheetsMacroTest extends TestCase
 {
-    public function testMacro()
+    public function test_macro()
     {
         Sheets::macro('test', function () {
             return 'test';
@@ -19,7 +19,7 @@ public function testMacro()
         $this->assertSame('test', $test);
     }
 
-    public function testMacroException()
+    public function test_macro_exception()
     {
         $this->expectException(\BadMethodCallException::class);