Move types into repo (#2037)

* prepare new types pacakge

* move shared types to controller

- build fails now

* add dummy nx.json

- install types package correctly
- try devDep attr

* monorepo dep should be enough for types

* adjust tsconfig to load local types

* fix some types to fix build

* automatically extract api

* directly export Adapter and AdapterOptions from adapter.ts

* add tests for types

* fixed export and types

* fix ts

* fix build

* fix tests

Author: foxriver76

.eslintrc.js

@@ -147,6 +147,100 @@ module.exports = {
                 ],
                 '@typescript-eslint/no-this-alias': 'off',
 
+                // Prefer simple property access and declaration without quotes
+                'dot-notation': 'off',
+                '@typescript-eslint/dot-notation': [
+                    'error',
+                    {
+                        allowPrivateClassPropertyAccess: true,
+                        allowProtectedClassPropertyAccess: true
+                    }
+                ],
+                'quote-props': ['error', 'as-needed']
+            }
+        },
+        // test-d.ts files
+        {
+            parser: '@typescript-eslint/parser',
+            parserOptions: {
+                ecmaVersion: 2019,
+                sourceType: 'module',
+                project: './tsconfig.json'
+            },
+            files: ['**/*.test-d.ts'],
+            extends: ['plugin:@typescript-eslint/recommended'],
+            rules: {
+                '@typescript-eslint/no-empty-function': 'off',
+                '@typescript-eslint/no-parameter-properties': 'off',
+                '@typescript-eslint/no-explicit-any': 'off',
+                '@typescript-eslint/no-use-before-define': [
+                    'error',
+                    {
+                        functions: false,
+                        typedefs: false,
+                        classes: false
+                    }
+                ],
+                '@typescript-eslint/no-unused-vars': [
+                    'off',
+                    {
+                        ignoreRestSiblings: true,
+                        argsIgnorePattern: '^_'
+                    }
+                ],
+                '@typescript-eslint/no-object-literal-type-assertion': 'off',
+                '@typescript-eslint/interface-name-prefix': 'off',
+                '@typescript-eslint/no-non-null-assertion': 'off', // This is necessary for Map.has()/get()!
+                '@typescript-eslint/no-inferrable-types': [
+                    'error',
+                    {
+                        ignoreProperties: true,
+                        ignoreParameters: true
+                    }
+                ],
+                '@typescript-eslint/ban-ts-comment': [
+                    'error',
+                    {
+                        'ts-expect-error': false,
+                        'ts-ignore': true,
+                        'ts-nocheck': true,
+                        'ts-check': false
+                    }
+                ],
+                '@typescript-eslint/restrict-template-expressions': [
+                    'error',
+                    {
+                        allowNumber: true,
+                        allowBoolean: true,
+                        // This is necessary to log errors
+                        // TODO: Consider switching to false when we may annotate catch clauses
+                        allowAny: true,
+                        allowNullish: true
+                    }
+                ],
+                '@typescript-eslint/no-misused-promises': [
+                    'error',
+                    {
+                        checksVoidReturn: false
+                    }
+                ],
+                // We can turn this on from time to time but in general these rules
+                // make our lives harder instead of easier
+                '@typescript-eslint/no-unsafe-argument': 'off',
+                '@typescript-eslint/no-unsafe-assignment': 'off',
+                '@typescript-eslint/no-unsafe-member-access': 'off',
+                '@typescript-eslint/no-unsafe-return': 'off',
+                '@typescript-eslint/no-unsafe-call': 'off',
+
+                // Although this rule makes sense, it takes about a second to execute (and we don't need it)
+                '@typescript-eslint/no-implied-eval': 'off',
+
+                '@typescript-eslint/explicit-module-boundary-types': [
+                    'warn',
+                    { allowArgumentsExplicitlyTypedAsAny: true }
+                ],
+                '@typescript-eslint/no-this-alias': 'off',
+
                 // Prefer simple property access and declaration without quotes
                 'dot-notation': 'off',
                 '@typescript-eslint/dot-notation': [

.github/workflows/ci-tests.yml

@@ -86,6 +86,9 @@ jobs:
       - name: Run scripts
         run: npm run preinstall && npm run install
 
+      - name: Execute Type Tests
+        run: npm run test-types
+
       - name: Execute Standard Tests
         run: npm test
 

nx.json

@@ -0,0 +1,24 @@
+{
+  "tasksRunnerOptions": {
+    "default": {
+      "runner": "nx/tasks-runners/default",
+      "options": {
+        "cacheableOperations": [],
+        "parallel": 5
+      }
+    }
+  },
+  "targetDefaults": {
+    "build": {
+      "dependsOn": [
+        "^build",
+        "prebuild"
+      ]
+    },
+    "test": {
+      "dependsOn": [
+        "build"
+      ]
+    }
+  }
+}