Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to Typescript 4.4.2 breaks Ionicons 5.5.3 #1000

Closed
dorontal opened this issue Aug 27, 2021 · 4 comments
Closed

Upgrading to Typescript 4.4.2 breaks Ionicons 5.5.3 #1000

dorontal opened this issue Aug 27, 2021 · 4 comments

Comments

@dorontal
Copy link

dorontal commented Aug 27, 2021

Just upgraded typescript (from version 4.3.5) and got these errors in the Ionicons type definitions, as reported when running yarn start inside an Ionic project that uses Ionicons 5.5.3:

Error: node_modules/ionicons/dist/types/components.d.ts:66:15 - error TS2320: Interface 'HTMLIonIconElement' cannot simultaneously extend types 'IonIcon' and 'HTMLStencilElement'.
  Named property 'ariaHidden' of types 'IonIcon' and 'HTMLStencilElement' are not identical.

66     interface HTMLIonIconElement extends Components.IonIcon, HTMLStencilElement {
                 ~~~~~~~~~~~~~~~~~~

NOTE: Typescript reports similar errors for code within it's own repository (further errors with the above build were reported in node_modules/typescript/lib/lib.dom.d.ts) so this may be a problem with Typescript 4.4.2 itself and who knows, when that is fixed, it may fix this problem automatically. Not sure.

But the current combination of Typescript version 4.4.2 and Ionicons version 5.5.3 is broken.

@shivagouraram
Copy link

Yes, I too faced this issue today. I had to downgrade the typescript to make it work.

@GothShoot
Copy link

Same problem for me.

@Ripwords
Copy link

Ripwords commented Oct 5, 2021

The issue can be worked around by adding a config option in tsconfig mentioned here

@liamdebeasi
Copy link
Contributor

Thanks for the issue. I am going to close this as a duplicate of #1011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants