Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfills are included when includeDefineCustomElements is true in config, even when includePolyfills is false. #361

Closed
iryan2 opened this issue Mar 26, 2021 · 2 comments · Fixed by #428
Labels
package: react @stencil/react-output-target package

Comments

@iryan2
Copy link

iryan2 commented Mar 26, 2021

Stencil version:

 @stencil/core@2.4.0

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:
Polyfills are included when includeDefineCustomElements is true in config, even when includePolyfills is false.

Expected behavior:
the /dist/esm/polyfiles/core-js.js and /dist/esm/polyfills/dom.js files would not be included in the build of a consuming application

Steps to reproduce:

  • Use the following config:
    reactOutputTarget({
      componentCorePackage: '@wclib/core',
      proxiesFile: '../wclib-react/src/components.ts',
      includeDefineCustomElements: true,
      includePolyfills: false,
    })
  • Use a component in a fresh create-react-app
  • build the CRA bundle
  • use source-map-explorer to find out what's causing the ~100KB bloat
  • discover that it's polyfills from stencil:
    image
@ionitron-bot ionitron-bot bot added the triage label Mar 26, 2021
@ionitron-bot ionitron-bot bot removed the triage label Nov 14, 2021
@rwaskiewicz rwaskiewicz transferred this issue from ionic-team/stencil Jun 28, 2023
@ionitron-bot ionitron-bot bot added the triage label Jun 28, 2023
@rwaskiewicz rwaskiewicz added the package: react @stencil/react-output-target package label Jun 28, 2023
@ionitron-bot ionitron-bot bot removed the triage label Jun 28, 2023
@christian-bromann
Copy link
Member

Fixed in #432

Copy link

ionitron-bot bot commented Nov 11, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the output targets, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: react @stencil/react-output-target package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants