fix(react): ssr hydration with children #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner-reits
approved these changes
Aug 28, 2024
sean-perkins
approved these changes
Aug 28, 2024
| serializedChildren = ReactDOMServer.renderToString(awaitedChildren); | ||
| } catch (err: unknown) { | ||
| const error = err instanceof Error ? err : new Error('Unknown error'); | ||
| console.log( |
There was a problem hiding this comment.
~ No action needed. Is a serialization failure actionable for the developer? If so, thoughts on elevating this to a warning?
There was a problem hiding this comment.
Good suggestion, I can tweak this with my next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
It seems I made a mistake when rebasing my previous nextjs dev branch and missed what I implemented in #447.
What is the new behavior?
Reapply what's in that PR + adding additional tests.
Does this introduce a breaking change?
Other information