Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM_ParseExt handles unterminated strings incorrectly #443

Open
andwj opened this issue Feb 17, 2020 · 0 comments
Open

COM_ParseExt handles unterminated strings incorrectly #443

andwj opened this issue Feb 17, 2020 · 0 comments

Comments

@andwj
Copy link

andwj commented Feb 17, 2020

The string handling in COM_ParseExt() in q_shared.c will do the wrong thing when encountering the end of the string, the NUL character -- it will update data_p with a pointer to the character PAST the nul byte, so the next call to COM_ParseExt will read characters beyond the end of the buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant