fix: repo query builder

Author: diyor28

pkg/repo/repo.go

@@ -79,12 +79,13 @@ func Update(tableName string, fields []string, where ...string) string {
 		setFields[i] = fmt.Sprintf("%s = $%d", field, i+1)
 	}
 
-	return fmt.Sprintf(
-		"UPDATE %s SET %s %s",
-		tableName,
-		strings.Join(setFields, ", "),
-		strings.Join(where, " AND "),
-	)
+	q := fmt.Sprintf("UPDATE %s SET %s", tableName, strings.Join(setFields, ", "))
+
+	if len(where) > 0 {
+		q += " " + JoinWhere(where...)
+	}
+
+	return q
 }
 
 // BatchInsertQueryN creates a parameterized SQL query for batch inserting multiple values per row

pkg/repo/repo_test.go

@@ -0,0 +1,146 @@
+package repo
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestInsert(t *testing.T) {
+	tests := []struct {
+		name      string
+		tableName string
+		fields    []string
+		returning []string
+		want      string
+	}{
+		{
+			name:      "basic insert",
+			tableName: "users",
+			fields:    []string{"name", "email", "password"},
+			returning: []string{"id", "created_at"},
+			want:      "INSERT INTO users (name, email, password) VALUES ($1, $2, $3) RETURNING id, created_at",
+		},
+		{
+			name:      "single field",
+			tableName: "status",
+			fields:    []string{"value"},
+			returning: []string{"id"},
+			want:      "INSERT INTO status (value) VALUES ($1) RETURNING id",
+		},
+		{
+			name:      "with schema",
+			tableName: "public.products",
+			fields:    []string{"name", "price", "category_id"},
+			returning: []string{"id", "created_at", "updated_at"},
+			want:      "INSERT INTO public.products (name, price, category_id) VALUES ($1, $2, $3) RETURNING id, created_at, updated_at",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := Insert(tt.tableName, tt.fields, tt.returning...)
+			assert.Equal(t, tt.want, got)
+		})
+	}
+}
+
+func TestUpdate(t *testing.T) {
+	tests := []struct {
+		name      string
+		tableName string
+		fields    []string
+		where     []string
+		want      string
+	}{
+		{
+			name:      "basic update",
+			tableName: "users",
+			fields:    []string{"name", "email"},
+			where:     []string{"id = $3"},
+			want:      "UPDATE users SET name = $1, email = $2 WHERE id = $3",
+		},
+		{
+			name:      "single field",
+			tableName: "status",
+			fields:    []string{"value"},
+			where:     []string{"id = $2"},
+			want:      "UPDATE status SET value = $1 WHERE id = $2",
+		},
+		{
+			name:      "multiple conditions",
+			tableName: "products",
+			fields:    []string{"name", "price", "updated_at"},
+			where:     []string{"id = $4", "category_id = $5"},
+			want:      "UPDATE products SET name = $1, price = $2, updated_at = $3 WHERE id = $4 AND category_id = $5",
+		},
+		{
+			name:      "with schema",
+			tableName: "public.orders",
+			fields:    []string{"status", "updated_at"},
+			where:     []string{"id = $3"},
+			want:      "UPDATE public.orders SET status = $1, updated_at = $2 WHERE id = $3",
+		},
+		{
+			name:      "no conditions",
+			tableName: "settings",
+			fields:    []string{"value", "updated_at"},
+			where:     []string{},
+			want:      "UPDATE settings SET value = $1, updated_at = $2",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := Update(tt.tableName, tt.fields, tt.where...)
+			assert.Equal(t, tt.want, got)
+		})
+	}
+}
+
+func TestBatchInsertQueryN(t *testing.T) {
+	tests := []struct {
+		name      string
+		baseQuery string
+		rows      [][]interface{}
+		wantQuery string
+		wantArgs  []interface{}
+	}{
+		{
+			name:      "empty rows",
+			baseQuery: "INSERT INTO users (name, email) VALUES",
+			rows:      [][]interface{}{},
+			wantQuery: "INSERT INTO users (name, email) VALUES",
+			wantArgs:  nil,
+		},
+		{
+			name:      "single row",
+			baseQuery: "INSERT INTO users (name, email) VALUES",
+			rows: [][]interface{}{
+				{"John", "[email protected]"},
+			},
+			wantQuery: "INSERT INTO users (name, email) VALUES ($1,$2)",
+			wantArgs:  []interface{}{"John", "[email protected]"},
+		},
+		{
+			name:      "multiple rows",
+			baseQuery: "INSERT INTO users (name, email) VALUES",
+			rows: [][]interface{}{
+				{"John", "[email protected]"},
+				{"Jane", "[email protected]"},
+				{"Bob", "[email protected]"},
+			},
+			wantQuery: "INSERT INTO users (name, email) VALUES ($1,$2),($3,$4),($5,$6)",
+			wantArgs:  []interface{}{"John", "[email protected]", "Jane", "[email protected]", "Bob", "[email protected]"},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			gotQuery, gotArgs := BatchInsertQueryN(tt.baseQuery, tt.rows)
+			assert.Equal(t, tt.wantQuery, gotQuery)
+			assert.Equal(t, tt.wantArgs, gotArgs)
+		})
+	}
+}
+