test: fix filepath checks on windows

Author: Stebalien

cli/parse_test.go

@@ -7,7 +7,7 @@ import (
 	"io/ioutil"
 	"net/url"
 	"os"
-	"path"
+	"path/filepath"
 	"strings"
 	"testing"
 
@@ -763,7 +763,7 @@ func TestFileArgs(t *testing.T) {
 	tmpFile1 := mkTempFile(t, "", "", "test1")
 	tmpFile2 := mkTempFile(t, tmpDir1, "", "toBeIgnored")
 	tmpFile3 := mkTempFile(t, tmpDir1, "", "test3")
-	ignoreFile := mkTempFile(t, tmpDir2, "", path.Base(tmpFile2.Name()))
+	ignoreFile := mkTempFile(t, tmpDir2, "", filepath.Base(tmpFile2.Name()))
 	tmpHiddenFile := mkTempFile(t, tmpDir1, ".test_hidden_file_*", "test")
 	defer func() {
 		for _, f := range []string{
@@ -790,27 +790,27 @@ func TestFileArgs(t *testing.T) {
 			parseErr: fmt.Errorf("argument %q is required", "path"),
 		},
 		{
-			cmd: words{"fileOp", "--ignore", path.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
+			cmd: words{"fileOp", "--ignore", filepath.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name()},
 			parseErr: fmt.Errorf(notRecursiveFmtStr, tmpDir1, "r"),
 		},
 		{
-			cmd: words{"fileOp", tmpFile1.Name(), "--ignore", path.Base(tmpFile2.Name()), "--ignore"}, f: nil,
+			cmd: words{"fileOp", tmpFile1.Name(), "--ignore", filepath.Base(tmpFile2.Name()), "--ignore"}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name()},
 			parseErr: fmt.Errorf("missing argument for option %q", "ignore"),
 		},
 		{
-			cmd: words{"fileOp", "-r", "--ignore", path.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
+			cmd: words{"fileOp", "-r", "--ignore", filepath.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name()},
 			parseErr: nil,
 		},
 		{
-			cmd: words{"fileOp", "--hidden", "-r", "--ignore", path.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
+			cmd: words{"fileOp", "--hidden", "-r", "--ignore", filepath.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name()}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name(), tmpHiddenFile.Name()},
 			parseErr: nil,
 		},
 		{
-			cmd: words{"fileOp", "-r", "--ignore", path.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name(), "--ignore", "anotherRule"}, f: nil,
+			cmd: words{"fileOp", "-r", "--ignore", filepath.Base(tmpFile2.Name()), tmpDir1, tmpFile1.Name(), "--ignore", "anotherRule"}, f: nil,
 			args:     words{tmpDir1, tmpFile1.Name(), tmpFile3.Name()},
 			parseErr: nil,
 		},
@@ -838,7 +838,7 @@ func TestFileArgs(t *testing.T) {
 		}
 		expectedFileMap := make(map[string]bool)
 		for _, arg := range tc.args {
-			expectedFileMap[path.Base(arg)] = false
+			expectedFileMap[filepath.Base(arg)] = false
 		}
 		it := req.Files.Entries()
 		for it.Next() {