feat: kubo 0.43.0, electron 43 (#3188)

* chore: kubo 0.43.0-rc1

Release candidate, for smoke-testing ahead of the v0.43.0 final.

* chore: electron 43.2.0

Brings Chromium 150 and V8 15.0; Node stays on 24.x. None of the
Electron 43 breaking changes reach this app: both showOpenDialog call
sites already pass an explicit defaultPath, showHiddenFiles is unused,
toBitmap is never called, and no window sets titleBarOverlay. The splash
is the only frameless window and its artwork clears the new 8 DIP corner
clip on Linux, so roundedCorners keeps its default.

ensure-electron.js justified its own download path by naming extract-zip,
which electron's install.js no longer uses. Reword around the reason that
still holds, and drop the version-specific framing so it survives the
next bump.

* fix: capture screenshots in the main process

Electron 17 removed desktopCapturer from the renderer, so the preload
has seen it as undefined ever since this app moved to Electron 17 in
v0.19.0, and both the tray item and the global shortcut have thrown a
TypeError on every use. No webPreferences setting brings it back:
sandbox:false and nodeIntegration:true each still leave it undefined.

Capture where the API actually lives instead, asking for thumbnails at
the display's pixel size so they are full-resolution grabs rather than
previews. That drops the renderer round-trip along with getUserMedia,
ImageCapture and the canvas data URL.

- take-screenshot: captureScreens() over desktopCapturer and screen
- webui/screenshot.js and its preload hook are gone
- ipc-main-events: nothing sends SCREENSHOT any more

An empty thumbnail is how a missing macOS screen-recording grant
presents itself, so treat "no usable screen" as an error and raise the
existing notification rather than failing silently.

Closes #2306

* fix(macos): fetch kubo from github releases

kubo 0.43 deprecated distUrl: passing it at all takes the old
dist.ipfs.tech code path and prints a deprecation notice on every build.
The universal binary step was the last caller still doing that, so move
it to releasesUrl, which is where the package already defaults.

Matches #3180, which this branch otherwise supersedes by pinning the
published kubo release rather than a git revision.

* chore: kubo 0.43.0-rc2

* chore: npm audit fix

Resolves 15 advisories in transitive dependencies, all within the
existing semver ranges, so package.json is unchanged.

The 14 remaining need `npm audit fix --force`, which would install
ipfsd-ctl@17 as a breaking change.

* chore: kubo 0.43.0

Author: lidel

package-lock.json

@@ -53,7 +53,7 @@
     "@playwright/test": "^1.50.0",
     "cross-env": "^7.0.3",
     "dotenv": "^16.0.0",
-    "electron": "^42.3.3",
+    "electron": "^43.2.0",
     "electron-builder": "26.15.2",
     "got": "^12.0.3",
     "ipfs-or-gateway": "^4.1.0",
@@ -85,7 +85,7 @@
     "ipfs-utils": "^9.0.10",
     "ipfsd-ctl": "10.0.6",
     "it-last": "^1.0.6",
-    "kubo": "0.42.0",
+    "kubo": "0.43.0",
     "multiaddr": "10.0.1",
     "multiaddr-to-uri": "8.0.0",
     "portfinder": "^1.0.32",

package.json

@@ -43,7 +43,7 @@ const execLog = (cmd) => {
       version: kuboVersion,
       platform: 'darwin',
       arch: arch,
-      distUrl: 'https://dist.ipfs.tech',
+      releasesUrl: 'https://github.com/ipfs/kubo/releases',
       installPath: archDir
     })
     console.log(`→ Downloaded ${arch} version to ${archDir}`)

pkgs/macos/build-universal-kubo-binary.js

@@ -1,17 +1,16 @@
 'use strict'
 
-// Electron 42 stopped downloading its binary during `postinstall` (npm
+// The electron package does not download its binary during `postinstall` (npm
 // supply-chain hardening); it is fetched lazily on first run of the electron
 // bin. Our tests `require('electron')` in a plain Node context, which reads
 // node_modules/electron/path.txt synchronously, so the binary must be on disk
 // before the (parallel) Playwright workers start.
 //
 // We download via @electron/get (awaited, so a failed fetch is loud) and
-// extract with the platform's system unzip. Electron's own install.js, and the
-// extract-zip library it uses, extract on an async code path that does not keep
-// the Node event loop alive on the CI runners: the process exits mid-extract
-// (leaving an empty dist/) or, if held open, hangs. A synchronous, time-bounded
-// system extraction avoids both.
+// extract with the platform's system unzip. Electron's own install.js extracts
+// on an async code path with no lock around node_modules/electron/dist, which
+// on the CI runners has exited mid-extract (leaving an empty dist/) or hung. A
+// single synchronous, time-bounded system extraction avoids both.
 
 const { execFileSync } = require('child_process')
 const fs = require('fs')

scripts/ensure-electron.js

@@ -10,7 +10,6 @@ const ipcMainEvents = Object.freeze({
   MENUBAR_OPEN: 'menubar-will-open',
   UPDATING: 'updating',
   UPDATING_ENDED: 'updatingEnded',
-  SCREENSHOT: 'screenshot',
   COUNTLY_ADD_CONSENT: 'countly.addConsent',
   COUNTLY_REMOVE_CONSENT: 'countly.removeConsent',
   ONLINE_STATUS_CHANGED: 'online-status-changed',

src/common/ipc-main-events.js

@@ -1,12 +1,11 @@
 const i18n = require('i18next')
-const { clipboard, nativeImage, ipcMain } = require('electron')
+const { clipboard, desktopCapturer, screen } = require('electron')
 const logger = require('./common/logger')
 const { IS_MAC } = require('./common/consts')
 const { notify, notifyError } = require('./common/notify')
 const { SCREENSHOT_SHORTCUT: CONFIG_KEY } = require('./common/config-keys')
 const setupGlobalShortcut = require('./utils/setup-global-shortcut')
 const { analyticsKeys } = require('./analytics/keys')
-const ipcMainEvents = require('./common/ipc-main-events')
 const getCtx = require('./context')
 
 const SHORTCUT = IS_MAC
@@ -49,63 +48,80 @@ function onError (e) {
   })
 }
 
-function handleScreenshot () {
+// Ask for thumbnails at the display's pixel size, which is what makes them
+// full-resolution grabs rather than previews. getSources rejects fractional
+// dimensions, so round before handing the size over.
+async function captureScreens () {
+  const { size, scaleFactor } = screen.getPrimaryDisplay()
+
+  const sources = await desktopCapturer.getSources({
+    types: ['screen'],
+    thumbnailSize: {
+      width: Math.round(size.width * scaleFactor),
+      height: Math.round(size.height * scaleFactor)
+    }
+  })
+
+  // An empty thumbnail is how a missing screen-recording grant surfaces on
+  // macOS: getSources still lists the display, it just hands back nothing.
+  return sources.filter(({ thumbnail }) => !thumbnail.isEmpty())
+}
+
+async function takeScreenshot () {
   const ctx = getCtx()
   const launchWebUI = ctx.getFn('launchWebUI')
   const getIpfsd = ctx.getFn('getIpfsd')
-  return async (_, output) => {
-    const ipfsd = await getIpfsd()
+  const ipfsd = await getIpfsd()
 
-    if (!ipfsd) {
-      return
-    }
+  if (!ipfsd) {
+    return
+  }
+
+  const ipfs = ipfsd.api
+
+  if (!ipfs) {
+    logger.info('[screenshot] daemon not running')
+    return
+  }
 
-    const ipfs = ipfsd.api
+  try {
+    logger.info('[screenshot] taking screenshot')
+    const screens = await captureScreens()
 
-    if (!ipfs) {
-      logger.info('[screenshot] daemon not running')
-      return
+    if (screens.length === 0) {
+      throw new Error('no screen could be captured, screen recording may not be permitted')
     }
 
-    try {
-      await makeScreenshotDir(ipfs)
-      const isDir = output.length > 1
-      const d = new Date()
-      const pad = n => String(n).padStart(2, '0')
-      const date = `${d.getFullYear()}-${pad(d.getMonth() + 1)}-${pad(d.getDate())}`
-      const time = `${pad(d.getHours())}${pad(d.getMinutes())}${pad(d.getMilliseconds())}`
-      let baseName = `/screenshots/${date}_${time}`
-
-      if (isDir) {
-        baseName += '/'
-        await ipfs.files.mkdir(baseName, { parents: true })
-      } else {
-        baseName += '.png'
-      }
-
-      logger.info(`[screenshot] started: writing screenshots to ${baseName}`, { withAnalytics: analyticsKeys.SCREENSHOT_TAKEN })
-      let lastImage = null
-
-      for (const { name, image } of output) {
-        const img = nativeImage.createFromDataURL(image)
-        const path = isDir ? `${baseName}${name}.png` : baseName
-        const { cid } = await ipfs.add(img.toPNG(), { pin: false }) // no low level pin, presence in MFS will be enough to keep it around
-        await ipfs.files.cp(cid, path)
-        lastImage = img
-      }
-
-      logger.info(`[screenshot] completed: writing screenshots to ${baseName}`)
-      onSuccess(ipfs, launchWebUI, baseName, lastImage)
-    } catch (e) {
-      onError(e)
+    await makeScreenshotDir(ipfs)
+    const isDir = screens.length > 1
+    const d = new Date()
+    const pad = n => String(n).padStart(2, '0')
+    const date = `${d.getFullYear()}-${pad(d.getMonth() + 1)}-${pad(d.getDate())}`
+    const time = `${pad(d.getHours())}${pad(d.getMinutes())}${pad(d.getMilliseconds())}`
+    let baseName = `/screenshots/${date}_${time}`
+
+    if (isDir) {
+      baseName += '/'
+      await ipfs.files.mkdir(baseName, { parents: true })
+    } else {
+      baseName += '.png'
     }
-  }
-}
 
-async function takeScreenshot () {
-  const webui = await getCtx().getProp('webui')
-  logger.info('[screenshot] taking screenshot')
-  webui.webContents.send('screenshot')
+    logger.info(`[screenshot] started: writing screenshots to ${baseName}`, { withAnalytics: analyticsKeys.SCREENSHOT_TAKEN })
+    let lastImage = null
+
+    for (const { name, thumbnail } of screens) {
+      const path = isDir ? `${baseName}${name}.png` : baseName
+      const { cid } = await ipfs.add(thumbnail.toPNG(), { pin: false }) // no low level pin, presence in MFS will be enough to keep it around
+      await ipfs.files.cp(cid, path)
+      lastImage = thumbnail
+    }
+
+    logger.info(`[screenshot] completed: writing screenshots to ${baseName}`)
+    onSuccess(ipfs, launchWebUI, baseName, lastImage)
+  } catch (e) {
+    onError(e)
+  }
 }
 
 module.exports = function () {
@@ -120,8 +136,6 @@ module.exports = function () {
       takeScreenshot()
     }
   })
-
-  ipcMain.on(ipcMainEvents.SCREENSHOT, handleScreenshot())
 }
 
 module.exports.takeScreenshot = takeScreenshot

src/take-screenshot.js

@@ -1,11 +1,9 @@
 // @ts-check
 const { ipcRenderer, contextBridge } = require('electron')
-const screenshotHook = require('./screenshot')
 const connectionHook = require('./connection-status')
 const { COUNTLY_KEY, VERSION } = require('../common/consts')
 const ipcMainEvents = require('../common/ipc-main-events')
 
-screenshotHook()
 connectionHook()
 
 const urlParams = new URLSearchParams(window.location.search)