Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usermodel style color values are undocumented despite having specific limitations. #274

Open
zaphar opened this issue Feb 8, 2025 · 2 comments
Assignees

Comments

@zaphar
Copy link

zaphar commented Feb 8, 2025

It appears that for color, the UserModel, minimally requires the values to be valid hex colors only. It will not allow named colors, css rgb(...) specifiers or others. In sheetui I allow both of those currently so would need to either convert them to hex formats before setting the styles or use the lower level model. Is the hex only approach in UserModel intentional?

I would be willing to prepare a PR to add some checking for other valid css values or minimally add documentation to the APi so consumers know what to pass in.

@nhatcher nhatcher self-assigned this Feb 10, 2025
@nhatcher
Copy link
Member

Hi @zaphar, give me a few days to think about this. So Excel saves them in hex format (I think!). That doesn't mean we have to. I think we definitely should accept named colors,, rbg, etc.

@zaphar
Copy link
Author

zaphar commented Feb 10, 2025

Certainly. It's not super difficult to do the translation on my end so either way I can still work with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants