Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL support #155

Open
amitbeck opened this issue Jan 31, 2019 · 4 comments · May be fixed by #170
Open

RTL support #155

amitbeck opened this issue Jan 31, 2019 · 4 comments · May be fixed by #170

Comments

@amitbeck
Copy link

amitbeck commented Jan 31, 2019 •
edited
Loading

Currently, the context menu has no support for setting dir. For example, even when dir: rtl CSS rule is applied, the submenu still has an arrow pointing to the right and is opened on the right, instead of opening (& the arrow pointing) to the left.
This isn't too much of an issue, but it would be nice if the context menu could adjust according to the directionality.
@isaacplmann
Copy link
Owner

That would be a nice feature to add. Interested in working on a PR? I can guide you through it.

@amitbeck
Copy link
Author

I'd love to.

@myalsailamy
Copy link

I need this feature. :(

@amitbeck amitbeck linked a pull request Sep 4, 2019 that will close this issue
Open
@sroucheray
Copy link
Contributor

I implemented it in this forks https://github.com/PerfectMemory/ngx-contextmenu available on NPM https://www.npmjs.com/package/@perfectmemory/ngx-contextmenu

While the principles are the same, note that the API in the fork has been slightly modified in version 8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bidi): Implement RTL support amitbeck/ngx-contextmenu
4 participants
@sroucheray @isaacplmann @myalsailamy @amitbeck